search: make xap_terms easier-to-use and use it more

This allows us to simplify callers throughout, and exceptions are
can no longer be silently hidden.  MiscSearch now uses xap_terms
for looking up eidx_key terms for a code reduction.

We also simplify LeiStore->_msg_kw for runtime use by moving the
MsetIterator handling into t/lei_store.t test case.

1 files changed, 2 insertions, 2 deletions

diff --git a/lib/PublicInbox/LeiXSearch.pm b/lib/PublicInbox/LeiXSearch.pm
index beb955bb..cac7fb7d 100644
--- a/lib/PublicInbox/LeiXSearch.pm
+++ b/lib/PublicInbox/LeiXSearch.pm
@@ -71,11 +71,11 @@ sub _mitem_kw { # retry_reopen callback
         my $doc = $mitem->get_document;
         my $kw = xap_terms('K', $doc);
         $kw->{flagged} = 1 if $flagged;
-        my $L = xap_terms('L', $doc);
+        my @L = xap_terms('L', $doc);
         # we keep the empty {kw} array here to prevent expensive work in
         # ->xsmsg_vmd, _unbless_smsg will clobber it iff it's empty
         $smsg->{kw} = [ sort keys %$kw ];
-        $smsg->{L} = [ sort keys %$L ] if scalar(keys %$L);
+        $smsg->{L} = \@L if scalar(@L);
 }
 
 sub mitem_kw ($$$;$) {