diff options
| author | Eric Wong <e@80x24.org> | 2021-03-22 07:53:59 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2021-03-23 00:07:12 +0000 |
| commit | d4b8980b9d2305c3004ff076a83006cc20502e56 (patch) | |
| tree | 9fc5aca5d117d04a4c7b7ff2f5b9a818f3b9372c /lib/PublicInbox/InboxWritable.pm | |
| parent | c61dc9e3b1d4e8fb0035461dced3f46853535e80 (diff) | |
| download | public-inbox-d4b8980b9d2305c3004ff076a83006cc20502e56.tar.gz | |
mbox_reader: add ->reads method to avoid nonsensical formats
Relying on UNIVERSAL::can may cause internal helper methods to be used, which can lead to failures or nonsensical results.
Diffstat (limited to 'lib/PublicInbox/InboxWritable.pm')
| -rw-r--r-- | lib/PublicInbox/InboxWritable.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/InboxWritable.pm b/lib/PublicInbox/InboxWritable.pm index c2baeba6..eeebc485 100644 --- a/lib/PublicInbox/InboxWritable.pm +++ b/lib/PublicInbox/InboxWritable.pm @@ -172,7 +172,7 @@ sub _mbox_eml_cb { # MboxReader->mbox* callback sub import_mbox { my ($self, $fh, $variant) = @_; require PublicInbox::MboxReader; - my $cb = PublicInbox::MboxReader->can($variant) or + my $cb = PublicInbox::MboxReader->reads($variant) or die "$variant not supported\n"; my $im = $self->importer(1); $cb->(undef, $fh, \&_mbox_eml_cb, $im, $self->filter); |