about summary refs log tree commit homepage
path: root/lib/PublicInbox/Inbox.pm
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-06-10 07:04:31 +0000
committerEric Wong <e@yhbt.net>2020-06-13 07:55:45 +0000
commitf1c9ad532f8dd46df172cfde85329a6e00ed1eab (patch)
tree0ea94c773af1126d54fc2f39e71f71a61985aeed /lib/PublicInbox/Inbox.pm
parent3c7c389f514f9123667926af1613b5c79833085c (diff)
downloadpublic-inbox-f1c9ad532f8dd46df172cfde85329a6e00ed1eab.tar.gz
Trying to avoid a circular reference by relying on $ibx object
here makes no sense, since skipping GitCatAsync::close will
result in an FD leak, anyways.  So keep GitAsyncCat contained to
git-only operations, since we'll be using it for Solver in the
distant feature.
Diffstat (limited to 'lib/PublicInbox/Inbox.pm')
-rw-r--r--lib/PublicInbox/Inbox.pm3
1 files changed, 0 insertions, 3 deletions
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 407751c3..b2b0b56f 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -22,9 +22,6 @@ my $CLEANUP = {}; # string(inbox) -> inbox
 sub git_cleanup ($) {
         my ($self) = @_;
         my $git = $self->{git} or return;
-        if (my $async_cat = delete $self->{async_cat}) {
-                $async_cat->close;
-        }
         $git->cleanup;
 }