about summary refs log tree commit homepage
path: root/lib/PublicInbox/Inbox.pm
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-06-01 10:06:51 +0000
committerEric Wong <e@yhbt.net>2020-06-03 04:04:21 +0000
commitd32333a12ca46861fab82640c3697fdbca879bd2 (patch)
tree5eda5e12f59165320a555a3b3a4c85ca47be72d3 /lib/PublicInbox/Inbox.pm
parent3ca8e5830e02bd42ea3b2b80733206c9aaafa4c0 (diff)
downloadpublic-inbox-d32333a12ca46861fab82640c3697fdbca879bd2.tar.gz
None of our current callers care about the size of the blob
we're retrieving, so stop wasting stack space and code for
it.
Diffstat (limited to 'lib/PublicInbox/Inbox.pm')
-rw-r--r--lib/PublicInbox/Inbox.pm24
1 files changed, 12 insertions, 12 deletions
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index bd1489e3..38abdfe5 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -310,25 +310,25 @@ sub nntp_usable {
 }
 
 # for v1 users w/o SQLite only
-sub msg_by_path ($$;$) {
-        my ($self, $path, $ref) = @_;
-        git($self)->cat_file('HEAD:'.$path, $ref);
+sub msg_by_path ($$) {
+        my ($self, $path) = @_;
+        git($self)->cat_file('HEAD:'.$path);
 }
 
-sub msg_by_smsg ($$;$) {
-        my ($self, $smsg, $ref) = @_;
+sub msg_by_smsg ($$) {
+        my ($self, $smsg) = @_;
 
         # ghosts may have undef smsg (from SearchThread.node) or
         # no {blob} field
         return unless defined $smsg;
         defined(my $blob = $smsg->{blob}) or return;
 
-        git($self)->cat_file($blob, $ref);
+        git($self)->cat_file($blob);
 }
 
 sub smsg_mime {
-        my ($self, $smsg, $ref) = @_;
-        if (my $s = msg_by_smsg($self, $smsg, $ref)) {
+        my ($self, $smsg) = @_;
+        if (my $s = msg_by_smsg($self, $smsg)) {
                 $smsg->{mime} = PublicInbox::Eml->new($s);
                 return $smsg;
         }
@@ -355,14 +355,14 @@ sub smsg_by_mid ($$) {
         PublicInbox::Smsg::psgi_cull($smsg);
 }
 
-sub msg_by_mid ($$;$) {
-        my ($self, $mid, $ref) = @_;
+sub msg_by_mid ($$) {
+        my ($self, $mid) = @_;
 
         over($self) or
-                return msg_by_path($self, mid2path($mid), $ref);
+                return msg_by_path($self, mid2path($mid));
 
         my $smsg = smsg_by_mid($self, $mid);
-        $smsg ? msg_by_smsg($self, $smsg, $ref) : undef;
+        $smsg ? msg_by_smsg($self, $smsg) : undef;
 }
 
 sub recent {