about summary refs log tree commit homepage
path: root/lib/PublicInbox/Inbox.pm
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-04-18 03:38:53 +0000
committerEric Wong <e@yhbt.net>2020-04-19 08:51:29 +0000
commit0c586dc64b3b6642a894e125d09df446667a4079 (patch)
tree38d6b349b64e6395e1910aaae2ef450b06d96a13 /lib/PublicInbox/Inbox.pm
parent92de3139920992bfad32ef927153f27addfdc72c (diff)
downloadpublic-inbox-0c586dc64b3b6642a894e125d09df446667a4079.tar.gz
It's unnecessary overhead for anything which does Email::MIME
parsing.  It was never done for v2 indexing, even though v1->v2
conversions did NOT remove those From_ lines.  There was never a
need to remote From_ lines the v1 SearchIdx paths, either.

Hitting a /$INBOX_URL/$MSGID/T/ endpoint with an 18 message
thread reveals a ~0.5% speed improvement.  This will become
more apparent when we have a faster MIME parser.
Diffstat (limited to 'lib/PublicInbox/Inbox.pm')
-rw-r--r--lib/PublicInbox/Inbox.pm8
1 files changed, 2 insertions, 6 deletions
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 4bd82989..186eb420 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -311,9 +311,7 @@ sub nntp_usable {
 # for v1 users w/o SQLite only
 sub msg_by_path ($$;$) {
         my ($self, $path, $ref) = @_;
-        my $str = git($self)->cat_file('HEAD:'.$path, $ref);
-        $$str =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s if $str;
-        $str;
+        git($self)->cat_file('HEAD:'.$path, $ref);
 }
 
 sub msg_by_smsg ($$;$) {
@@ -324,9 +322,7 @@ sub msg_by_smsg ($$;$) {
         return unless defined $smsg;
         defined(my $blob = $smsg->{blob}) or return;
 
-        my $str = git($self)->cat_file($blob, $ref);
-        $$str =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s if $str;
-        $str;
+        git($self)->cat_file($blob, $ref);
 }
 
 sub smsg_mime {