about summary refs log tree commit homepage
path: root/lib/PublicInbox/Inbox.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2017-01-07 22:56:03 +0000
committerEric Wong <e@80x24.org>2017-01-07 23:38:29 +0000
commit0753326bc4f148436b4c34dfb8133b5579de0198 (patch)
tree1e84c00d856c0c78481ed8c5488726597a0d524c /lib/PublicInbox/Inbox.pm
parentb3df50ef7ed4bc7f48881192bc4f8c103331904d (diff)
downloadpublic-inbox-0753326bc4f148436b4c34dfb8133b5579de0198.tar.gz
We never used this feature, so lets drop it for now
since we can have fine-grained memory release with
reference counting, anyways.
Diffstat (limited to 'lib/PublicInbox/Inbox.pm')
-rw-r--r--lib/PublicInbox/Inbox.pm16
1 files changed, 8 insertions, 8 deletions
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 5503980f..15db929e 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -211,16 +211,16 @@ sub nntp_usable {
         $ret;
 }
 
-sub msg_by_path ($$;$) {
+sub msg_by_path ($$) {
         my ($self, $path, $ref) = @_;
         # TODO: allow other refs:
-        my $str = git($self)->cat_file('HEAD:'.$path, $ref);
+        my $str = git($self)->cat_file('HEAD:'.$path);
         $$str =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s if $str;
         $str;
 }
 
-sub msg_by_smsg ($$;$) {
-        my ($self, $smsg, $ref) = @_;
+sub msg_by_smsg ($$) {
+        my ($self, $smsg) = @_;
 
         return unless defined $smsg; # ghost
 
@@ -228,7 +228,7 @@ sub msg_by_smsg ($$;$) {
         # TODO: remove if we bump SCHEMA_VERSION in Search.pm:
         defined(my $blob = $smsg->blob) or return msg_by_mid($self, $smsg->mid);
 
-        my $str = git($self)->cat_file($blob, $ref);
+        my $str = git($self)->cat_file($blob);
         $$str =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s if $str;
         $str;
 }
@@ -238,9 +238,9 @@ sub path_check {
         git($self)->check('HEAD:'.$path);
 }
 
-sub msg_by_mid ($$;$) {
-        my ($self, $mid, $ref) = @_;
-        msg_by_path($self, mid2path($mid), $ref);
+sub msg_by_mid ($$) {
+        my ($self, $mid) = @_;
+        msg_by_path($self, mid2path($mid));
 }
 
 1;