about summary refs log tree commit homepage
path: root/lib/PublicInbox/Import.pm
diff options
authorEric W. Biederman <ebiederm@xmission.com>2018-07-07 13:22:28 -0500
committerEric Wong <e@80x24.org>2018-07-07 23:02:13 +0000
commitaca47e05a6026c12c768753c87e6ff769ef6bee4 (patch)
tree5c84328b44e68f9a405f8c3437556177368b7cbc /lib/PublicInbox/Import.pm
parentae80a3fdb53d70142624f2691ed8ed84eddda66b (diff)
Recently I ran git --git-dir=lkml/git/1.git fsck
and it reported:
> warning in commit 299dbd50b6995c6debe2275f0df984ce697fb4cc: nulInCommit: NULL byte inthe commit object body

Which I found quite scary.  Nulls in the wrong place have a bad tendency
to make programs misbehave.

It turns out someone had placed "=?iso-8859-1?q?=00?=" at the end of
their subject line.  Which is the mime encoding for NULL.  Email::Mime
had correctly decoded the header, and then public-inbox had simply
copied the contents of the header into the subject line of the git

To prevent that from causing problems replace nulls in such subject
lines with spaces.

Signed-off-by: Eric Biederman <ebiederm@xmission.com>
Diffstat (limited to 'lib/PublicInbox/Import.pm')
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 250a2db3..f320c58c 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -405,6 +405,8 @@ sub add {
                 print $w "reset $ref\n" or wfail;
+        # Mime decoding can create nulls replace them with spaces to protect git
+        $subject =~ tr/\0/ /;
         print $w "commit $ref\nmark :$commit\n",
                 "author $name <$email> $author_time_raw\n",