diff options
author | Eric Wong <e@yhbt.net> | 2020-01-12 21:17:51 +0000 |
---|---|---|
committer | Eric Wong <e@yhbt.net> | 2020-01-13 23:21:25 +0000 |
commit | a65ebdc3a1f064bab0cddf64b34caad49f1c4c9c (patch) | |
tree | 2f3dea59884e4d6ee37393abd5f3a901593f4b79 /lib/PublicInbox/HTTP.pm | |
parent | 8f23c134b6c9bfc9f23b3eed7811082e6d33a84c (diff) | |
download | public-inbox-a65ebdc3a1f064bab0cddf64b34caad49f1c4c9c.tar.gz |
We can rely on autovification to turn `undef' value of {wbuf} into an arrayref. Furthermore, "push" returns the (new) size of the array since at least Perl 5.0 (I didn't look further back), so we can use that return value instead of calling "scalar" again.
Diffstat (limited to 'lib/PublicInbox/HTTP.pm')
-rw-r--r-- | lib/PublicInbox/HTTP.pm | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index 071251c6..32537153 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -280,12 +280,12 @@ sub getline_pull { } if ($self->{sock}) { - my $wbuf = $self->{wbuf} //= []; - push @$wbuf, \&getline_pull; + # autovivify wbuf + my $new_size = push(@{$self->{wbuf}}, \&getline_pull); # wbuf may be populated by {chunked,identity}_write() # above, no need to rearm if so: - $self->requeue if scalar(@$wbuf) == 1; + $self->requeue if $new_size == 1; return; # likely } } elsif ($@) { |