about summary refs log tree commit homepage
path: root/lib/PublicInbox/HTTP.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-11-26 08:52:50 +0000
committerEric Wong <e@80x24.org>2016-11-26 08:52:50 +0000
commitc008654229a9a693840ed30fadf6930bcd633b71 (patch)
treedffade86b539d195c04f312c8e3705251e0e0e42 /lib/PublicInbox/HTTP.pm
parent57024ca2ae548a103dae12efaaf2f852d2c47e0e (diff)
downloadpublic-inbox-c008654229a9a693840ed30fadf6930bcd633b71.tar.gz
We do not need to import IO::File into the main programs
since Perl 5.8+ supports literal "undef" for generating
anonymous temporary file handles.
Diffstat (limited to 'lib/PublicInbox/HTTP.pm')
-rw-r--r--lib/PublicInbox/HTTP.pm8
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 729d46fb..cac14be3 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -17,7 +17,7 @@ use Plack::HTTPParser qw(parse_http_request); # XS or pure Perl
 use HTTP::Status qw(status_message);
 use HTTP::Date qw(time2str);
 use Scalar::Util qw(weaken);
-use IO::File;
+use IO::Handle;
 use constant {
         CHUNK_START => -1,   # [a-f0-9]+\r\n
         CHUNK_END => -2,     # \r\n
@@ -43,7 +43,7 @@ sub process_pipelineq () {
 our $MAX_REQUEST_BUFFER = $ENV{GIT_HTTP_MAX_REQUEST_BUFFER} ||
                         (10 * 1024 * 1024);
 
-my $null_io = IO::File->new('/dev/null', '<');
+open(my $null_io, '<', '/dev/null') or die "failed to open /dev/null: $!";
 my $http_date;
 my $prev = 0;
 sub http_date () {
@@ -335,10 +335,10 @@ sub input_prepare {
                         quit($self, 413);
                         return;
                 }
-                $input = IO::File->new_tmpfile;
+                open($input, '+>', undef);
         } elsif (env_chunked($env)) {
                 $len = CHUNK_START;
-                $input = IO::File->new_tmpfile;
+                open($input, '+>', undef);
         }
 
         # TODO: expire idle clients on ENFILE / EMFILE