about summary refs log tree commit homepage
path: root/lib/PublicInbox/HTTP.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-07-07 01:39:36 +0000
committerEric Wong <e@80x24.org>2016-07-07 01:41:03 +0000
commit8e85257577ee4d7d49e59f048852d9d4ac6f8172 (patch)
tree83b62c2c283df344a6884cc45a5e16aad5c2196b /lib/PublicInbox/HTTP.pm
parent0cdb0320181606c9b663aa8e37d69a79bff6f3a1 (diff)
downloadpublic-inbox-8e85257577ee4d7d49e59f048852d9d4ac6f8172.tar.gz
This fixes some layering violations and consolidates
the cleanup into the inbox object itself.  Keeping in
mind weakening does not work at all without our PSGI
server.
Diffstat (limited to 'lib/PublicInbox/HTTP.pm')
-rw-r--r--lib/PublicInbox/HTTP.pm16
1 files changed, 0 insertions, 16 deletions
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index e19c592c..abf648f9 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -25,15 +25,6 @@ use constant {
         CHUNK_MAX_HDR => 256,
 };
 
-# FIXME: duplicated code with NNTP.pm, layering violation
-my $WEAKEN = {}; # string(inbox) -> inbox
-my $weakt;
-sub weaken_task () {
-        $weakt = undef;
-        $_->weaken_all for values %$WEAKEN;
-        $WEAKEN = {};
-}
-
 my $pipelineq = [];
 my $pipet;
 sub process_pipelineq () {
@@ -252,13 +243,6 @@ sub response_done ($$) {
         $self->{env} = undef;
         $self->write("0\r\n\r\n") if $alive == 2;
         $self->write(sub { $alive ? next_request($self) : $self->close });
-
-        # FIXME: layering violation
-        if (my $obj = $env->{'pi-httpd.inbox'}) {
-                # grace period for reaping resources
-                $WEAKEN->{"$obj"} = $obj;
-                PublicInbox::EvCleanup::later(*weaken_task);
-        }
 }
 
 sub getline_response {