diff options
author | Eric Wong <e@80x24.org> | 2019-12-29 12:51:18 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2019-12-30 00:06:23 +0000 |
commit | 267371b1273b518215939e817e53733584b68af7 (patch) | |
tree | 565515b689baf8e7384a384fd114d8d3f44546a2 /lib/PublicInbox/Git.pm | |
parent | 0a65fd278cb5b4e308fc2535753a3f1a5e78cbf4 (diff) | |
download | public-inbox-267371b1273b518215939e817e53733584b68af7.tar.gz |
We can save callers the trouble of {-hold} and {-dev_null} refs as well as the trouble of calling fileno().
Diffstat (limited to 'lib/PublicInbox/Git.pm')
-rw-r--r-- | lib/PublicInbox/Git.pm | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index af3a5712..8d587469 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -114,12 +114,12 @@ sub _bidi_pipe { my @cmd = (qw(git), "--git-dir=$self->{git_dir}", qw(-c core.abbrev=40 cat-file), $batch); - my $redir = { 0 => fileno($out_r), 1 => fileno($in_w) }; + my $redir = { 0 => $out_r, 1 => $in_w }; if ($err) { my $id = "git.$self->{git_dir}$batch.err"; my $fh = tmpfile($id) or fail($self, "tmpfile($id): $!"); $self->{$err} = $fh; - $redir->{2} = fileno($fh); + $redir->{2} = $fh; } my $p = spawn(\@cmd, undef, $redir); defined $p or fail($self, "spawn failed: $!"); |