about summary refs log tree commit homepage
path: root/lib/PublicInbox/Feed.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-08-14 10:21:09 +0000
committerEric Wong <e@80x24.org>2016-08-14 10:51:02 +0000
commit9d1e5fadd7d18f4c96ab0509d673040e34225a04 (patch)
treedd89df05390a2ca2e06448ec0acdbf741729d36e /lib/PublicInbox/Feed.pm
parent1d0ce406b75fc174bee51e77efe5f10c61fb6098 (diff)
downloadpublic-inbox-9d1e5fadd7d18f4c96ab0509d673040e34225a04.tar.gz
Based on reading RFC 3986, it seems '@', ':', '!', '$', '&',
"'", '; '(', ')', '*', '+', ',', ';', '=' are all allowed
in path-absolute where we have the Message-ID.

In any case, it seems '@' is fairly common in path components
nowadays and too common in Message-IDs.
Diffstat (limited to 'lib/PublicInbox/Feed.pm')
-rw-r--r--lib/PublicInbox/Feed.pm4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 240c336f..232a91c0 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -137,7 +137,7 @@ sub emit_atom_thread {
         my $fh = $cb->([200, ['Content-Type' => 'application/atom+xml']]);
         my $ibx = $ctx->{-inbox};
         my $html_url = $ibx->base_url($ctx->{env});
-        $html_url .= PublicInbox::Hval->new_msgid($mid)->as_href;
+        $html_url .= PublicInbox::Hval->new_msgid($mid)->{href};
 
         $feed_opts->{url} = $html_url;
         $feed_opts->{emit_header} = 1;
@@ -269,7 +269,7 @@ sub feed_entry {
         my $mid = $header_obj->header_raw('Message-ID');
         defined $mid or return;
         $mid = PublicInbox::Hval->new_msgid($mid);
-        my $href = $midurl . $mid->as_href . '/';
+        my $href = $midurl . $mid->{href}. '/';
 
         my $date = $header_obj->header('Date');
         my $updated = feed_updated($date);