reduce calls to close unless error checks are needed

We can rely on timely auto-destruction based on reference
counting; reducing the chance of redundant close(2) calls
which may hit the wront FD.

We do care about certain close calls (e.g. writing to a buffered
IO handle) if we require error-checking for write-integrity.  In
other cases, let things go out-of-scope so it can be freed
automatically after use.

1 files changed, 0 insertions, 2 deletions

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index a5828a8e..54cbf23c 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -255,7 +255,6 @@ sub each_recent_blob {
                 }
         }
 
-        close $log; # we may EPIPE here
         # for pagination
         ($first_commit, $last_commit);
 }
@@ -269,7 +268,6 @@ sub get_feedopts {
         my %rv;
         if (open my $fh, '<', "$ctx->{git_dir}/description") {
                 chomp($rv{description} = <$fh>);
-                close $fh;
         } else {
                 $rv{description} = '($GIT_DIR/description missing)';
         }