about summary refs log tree commit homepage
path: root/lib/PublicInbox/ExtMsg.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-08-14 10:21:09 +0000
committerEric Wong <e@80x24.org>2016-08-14 10:51:02 +0000
commit9d1e5fadd7d18f4c96ab0509d673040e34225a04 (patch)
treedd89df05390a2ca2e06448ec0acdbf741729d36e /lib/PublicInbox/ExtMsg.pm
parent1d0ce406b75fc174bee51e77efe5f10c61fb6098 (diff)
downloadpublic-inbox-9d1e5fadd7d18f4c96ab0509d673040e34225a04.tar.gz
Based on reading RFC 3986, it seems '@', ':', '!', '$', '&',
"'", '; '(', ')', '*', '+', ',', ';', '=' are all allowed
in path-absolute where we have the Message-ID.

In any case, it seems '@' is fairly common in path components
nowadays and too common in Message-IDs.
Diffstat (limited to 'lib/PublicInbox/ExtMsg.pm')
-rw-r--r--lib/PublicInbox/ExtMsg.pm6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 39ee05f4..67ce0407 100644
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -105,7 +105,7 @@ again:
 
         my $code = 404;
         my $h = PublicInbox::Hval->new_msgid($mid);
-        my $href = $h->as_href;
+        my $href = $h->{href};
         my $html = $h->as_html;
         my $title = "&lt;$html&gt; not found";
         my $s = "<pre>Message-ID &lt;$html&gt;\nnot found\n";
@@ -120,7 +120,7 @@ again:
                         my $u = $ibx->base_url($env) or next;
                         foreach my $m (@$res) {
                                 my $p = PublicInbox::Hval->new_msgid($m);
-                                my $r = $p->as_href;
+                                my $r = $p->{href};
                                 my $t = $p->as_html;
                                 $s .= qq{<a\nhref="$u$r/">$u$t/</a>\n};
                         }
@@ -158,7 +158,7 @@ sub ext_urls {
 sub exact {
         my ($ctx, $found, $mid) = @_;
         my $h = PublicInbox::Hval->new_msgid($mid);
-        my $href = $h->as_href;
+        my $href = $h->{href};
         my $html = $h->as_html;
         my $title = "&lt;$html&gt; found in ";
         my $end = @$found == 1 ? 'another inbox' : 'other inboxes';