diff options
author | Eric Wong <e@80x24.org> | 2019-09-25 22:49:52 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2019-09-25 22:49:52 +0000 |
commit | 17bec61580fe1eab9b60b01d990af9046a1cb031 (patch) | |
tree | 6643719d37f8b9e9f5231112cb55da36f21d4936 /lib/PublicInbox/DS.pm | |
parent | 4b3e278d9c4e5d1f55c1781aa0a7c9f0453f3852 (diff) | |
download | public-inbox-17bec61580fe1eab9b60b01d990af9046a1cb031.tar.gz |
The perl-5.16.3-294.el7_6 RPM package on RHEL/CentOS 7 is affected by a memory leak in Perl when calling `ref' on blessed references. This resulted in a very slow leak that manifests more quickly with a nonstop "git fetch" loop. Use Scalar::Util::blessed to work around the issue. Tested overnight on a CentOS 7 VM. cf. https://rt.perl.org/Public/Bug/Display.html?id=114340
Diffstat (limited to 'lib/PublicInbox/DS.pm')
-rw-r--r-- | lib/PublicInbox/DS.pm | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm index 30a9641a..7f7cb85d 100644 --- a/lib/PublicInbox/DS.pm +++ b/lib/PublicInbox/DS.pm @@ -24,6 +24,7 @@ use parent qw(Exporter); our @EXPORT_OK = qw(now msg_more); use warnings; use 5.010_001; +use Scalar::Util qw(blessed); use PublicInbox::Syscall qw(:epoll); use PublicInbox::Tmpfile; @@ -178,10 +179,12 @@ sub next_tick () { my $q = $nextq; $nextq = []; for (@$q) { - if (ref($_) eq 'CODE') { - $_->(); - } else { + # we avoid "ref" on blessed refs to workaround a Perl 5.16.3 leak: + # https://rt.perl.org/Public/Bug/Display.html?id=114340 + if (blessed($_)) { $_->event_step; + } else { + $_->(); } } } |