treewide: kill problematic "$h->{k} //= do {" assignments

As stated in the previous change, conditional hash assignments
which trigger other hash assignments seem problematic, at times.
So replace:

	$h->{k} //= do { $h->{x} = ...; $val };

	$h->{k} // do {
		$h->{x} = ...;
		$hk->{k} = $val
	};

"||=" is affected the same way, and some instances of "||=" are
replaced with "//=" or "// do {", now.

1 files changed, 3 insertions, 4 deletions

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 41117ac5..0f002e5e 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -377,8 +377,8 @@ sub get_1 {
 
 sub repo_objs {
         my ($self, $ibxish) = @_;
-        my $ibx_code_repos = $ibxish->{coderepo} or return;
-        $ibxish->{-repo_objs} //= do {
+        my $ibx_code_repos = $ibxish->{coderepo} // return;
+        $ibxish->{-repo_objs} // do {
                 my $code_repos = $self->{-code_repos};
                 my @repo_objs;
                 for my $nick (@$ibx_code_repos) {
@@ -395,10 +395,9 @@ sub repo_objs {
                         push @repo_objs, $repo if $repo;
                 }
                 if (scalar @repo_objs) {
-                        \@repo_objs;
+                        $ibxish ->{-repo_objs} = \@repo_objs;
                 } else {
                         delete $ibxish->{coderepo};
-                        undef;
                 }
         }
 }