about summary refs log tree commit homepage
path: root/lib/PublicInbox/Config.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2020-09-09 06:26:12 +0000
committerEric Wong <e@80x24.org>2020-09-10 19:45:18 +0000
commit352e2799ecec328f71aa33219214a0e3fc3d5f10 (patch)
tree4f1f22c286d613843d62c49d695a99f2ea05b08c /lib/PublicInbox/Config.pm
parentde9648ca847cf032aab6da9cac1217bf9cca9c90 (diff)
downloadpublic-inbox-352e2799ecec328f71aa33219214a0e3fc3d5f10.tar.gz
In Perl, we can simplify callers by passing a single array
all the way down the stack instead of a single array ref which
needs to be expanded every call.
Diffstat (limited to 'lib/PublicInbox/Config.pm')
-rw-r--r--lib/PublicInbox/Config.pm12
1 files changed, 6 insertions, 6 deletions
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index ae9ad8de..f78115b6 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -90,29 +90,29 @@ sub lookup_name ($$) {
 }
 
 sub each_inbox {
-        my ($self, $cb, $arg) = @_;
+        my ($self, $cb, @arg) = @_;
         # may auto-vivify if config file is non-existent:
         foreach my $section (@{$self->{-section_order}}) {
                 next if $section !~ m!\Apublicinbox\.([^/]+)\z!;
                 my $ibx = lookup_name($self, $1) or next;
-                $cb->($ibx, $arg);
+                $cb->($ibx, @arg);
         }
 }
 
 sub iterate_start {
-        my ($self, $cb, $arg) = @_;
+        my ($self, $cb, @arg) = @_;
         my $i = 0;
-        $self->{-iter} = [ \$i, $cb, $arg ];
+        $self->{-iter} = [ \$i, $cb, @arg ];
 }
 
 # for PublicInbox::DS::next_tick, we only call this is if
 # PublicInbox::DS is already loaded
 sub event_step {
         my ($self) = @_;
-        my ($i, $cb, $arg) = @{$self->{-iter}};
+        my ($i, $cb, @arg) = @{$self->{-iter}};
         my $section = $self->{-section_order}->[$$i++];
         delete($self->{-iter}) unless defined($section);
-        eval { $cb->($self, $section, $arg) };
+        eval { $cb->($self, $section, @arg) };
         warn "E: $@ in ${self}::event_step" if $@;
         PublicInbox::DS::requeue($self) if defined($section);
 }