about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-02-22 08:22:57 -0300
committerEric Wong <e@80x24.org>2021-02-22 18:14:22 -0400
commitf267821b1bef4488978a95f99fd0f837fdf475b7 (patch)
tree553d743086b45ca47d7ba23e18a4e89351a1cff0
parentfa5650d399f51a596e5c126b3ce65347409d4fe9 (diff)
downloadpublic-inbox-f267821b1bef4488978a95f99fd0f837fdf475b7.tar.gz
We only enable {mic_cached} in WQ workers, and those
aren't expected to fork again going forward.  So cache
here avoid a penalty for the non-augmenting (imap_delete_all)
call with "lei q"
-rw-r--r--lib/PublicInbox/NetReader.pm6
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm
index c29e09c1..ff90468b 100644
--- a/lib/PublicInbox/NetReader.pm
+++ b/lib/PublicInbox/NetReader.pm
@@ -426,7 +426,8 @@ sub mic_get {
         my ($self, $uri) = @_;
         my $sec = uri_section($uri);
         # see if caller saved result of imap_common_init
-        if (my $cached = $self->{mics_cached}) {
+        my $cached = $self->{mics_cached};
+        if ($cached) {
                 my $mic = $cached->{$sec};
                 return $mic if $mic && $mic->IsConnected;
                 delete $cached->{$sec};
@@ -439,7 +440,8 @@ sub mic_get {
                 }
         }
         my $mic = PublicInbox::IMAPClient->new(%$mic_arg);
-        $mic && $mic->IsConnected ? $mic : undef;
+        $cached //= {}; # invalid placeholder if no cache enabled
+        $mic && $mic->IsConnected ? ($cached->{$sec} = $mic) : undef;
 }
 
 sub imap_each {