about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-01-19 09:40:52 +0000
committerEric Wong <e@yhbt.net>2020-01-23 23:04:06 +0000
commitae469c583c2ddea48b5923af5986753251bf14ca (patch)
treeb8c1ebfdb85f569e7896fc2f7a8a394ea7d0082a
parentc242a28351d3a9a39224d35031d71afc02993c7a (diff)
downloadpublic-inbox-ae469c583c2ddea48b5923af5986753251bf14ca.tar.gz
We don't call from_attr anywhere outside of tests, so don't
bloat normal processes with it.
-rw-r--r--lib/PublicInbox/Hval.pm15
-rw-r--r--t/hval.t15
2 files changed, 15 insertions, 15 deletions
diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm
index 39256ee0..2589c519 100644
--- a/lib/PublicInbox/Hval.pm
+++ b/lib/PublicInbox/Hval.pm
@@ -10,7 +10,7 @@ use Encode qw(find_encoding);
 use PublicInbox::MID qw/mid_clean mid_escape/;
 use base qw/Exporter/;
 our @EXPORT_OK = qw/ascii_html obfuscate_addrs to_filename src_escape
-                to_attr from_attr prurl/;
+                to_attr prurl/;
 my $enc_ascii = find_encoding('us-ascii');
 
 # safe-ish acceptable filename pattern for portability
@@ -148,17 +148,4 @@ sub to_attr ($) {
         $first . $str;
 }
 
-# reverse the result of to_attr
-sub from_attr ($) {
-        my ($str) = @_;
-        my $first = '';
-        if ($str =~ s/\AZ([a-f0-9]{2})//ms) {
-                $first = chr(hex($1));
-        }
-        $str =~ s!::([a-f0-9]{2})!chr(hex($1))!egms;
-        $str =~ tr!:!/!;
-        utf8::decode($str);
-        $first . $str;
-}
-
 1;
diff --git a/t/hval.t b/t/hval.t
index f93d6be6..53f52f07 100644
--- a/t/hval.t
+++ b/t/hval.t
@@ -3,7 +3,20 @@
 use strict;
 use warnings;
 use Test::More;
-use_ok 'PublicInbox::Hval', qw(from_attr to_attr);
+use_ok 'PublicInbox::Hval', qw(to_attr);
+
+# reverse the result of to_attr
+sub from_attr ($) {
+        my ($str) = @_;
+        my $first = '';
+        if ($str =~ s/\AZ([a-f0-9]{2})//ms) {
+                $first = chr(hex($1));
+        }
+        $str =~ s!::([a-f0-9]{2})!chr(hex($1))!egms;
+        $str =~ tr!:!/!;
+        utf8::decode($str);
+        $first . $str;
+}
 
 my $ibx = {
         -no_obfuscate_re => qr/(?:example\.com)\z/i,