about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-06-30 00:01:55 +0000
committerEric Wong <e@80x24.org>2019-06-30 00:01:55 +0000
commit8ef878ebc6f9f3a337341a3aa42a84fc190032a3 (patch)
treefe38e193bfce3396243a94b01db479adbe89ab7f
parentf984b8ea898add0f67392723dd38c2ddd73dfa13 (diff)
downloadpublic-inbox-8ef878ebc6f9f3a337341a3aa42a84fc190032a3.tar.gz
Perl prior to 5.22 did not bundle a Net::NNTP (or libnet)
capable of handling TLS.
-rw-r--r--t/nntpd-tls.t3
-rw-r--r--t/nntpd.t9
2 files changed, 10 insertions, 2 deletions
diff --git a/t/nntpd-tls.t b/t/nntpd-tls.t
index 427d370f..e3ecdd4f 100644
--- a/t/nntpd-tls.t
+++ b/t/nntpd-tls.t
@@ -11,6 +11,9 @@ foreach my $mod (qw(DBD::SQLite IO::Socket::SSL Net::NNTP IO::Poll)) {
         eval "require $mod";
         plan skip_all => "$mod missing for $0" if $@;
 }
+Net::NNTP->can('starttls') or
+        plan skip_all => 'Net::NNTP does not support TLS';
+
 my $cert = 'certs/server-cert.pem';
 my $key = 'certs/server-key.pem';
 unless (-r $key && -r $cert) {
diff --git a/t/nntpd.t b/t/nntpd.t
index 6cba2be4..bf5bb883 100644
--- a/t/nntpd.t
+++ b/t/nntpd.t
@@ -106,8 +106,13 @@ EOF
         is_deeply($list, { $group => [ qw(1 1 n) ] }, 'LIST works');
         is_deeply([$n->group($group)], [ qw(0 1 1), $group ], 'GROUP works');
         is_deeply($n->listgroup($group), [1], 'listgroup OK');
-        ok(!$n->starttls, 'STARTTLS fails when unconfigured');
-        is($n->code, 580, 'got 580 code on server w/o TLS');
+
+        SKIP: {
+                $n->can('starttls') or
+                        skip('Net::NNTP too old to support STARTTLS', 2);
+                ok(!$n->starttls, 'STARTTLS fails when unconfigured');
+                is($n->code, 580, 'got 580 code on server w/o TLS');
+        };
 
         %opts = (
                 PeerAddr => $host_port,