about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-01-10 09:14:18 +0000
committerEric Wong <e@yhbt.net>2020-01-11 06:32:08 +0000
commit6d576feb27625abc36675b7b466265d4f06b2f26 (patch)
tree08aa365723d0f603fd7862a91e36c354c0ce0784
parent0615eef4e17b642eca6978cf776834a9f0a31468 (diff)
downloadpublic-inbox-6d576feb27625abc36675b7b466265d4f06b2f26.tar.gz
git: remove ->commit_title method
We haven't used it in SolverGit, yet, and I'll be reworking it
to work with ->cat_async, instead.
-rw-r--r--lib/PublicInbox/Git.pm7
-rw-r--r--t/solver_git.t6
2 files changed, 0 insertions, 13 deletions
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 9d0f660b..f3b7a0a0 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -332,13 +332,6 @@ sub cat_async ($$$;$) {
         push(@$inflight, [ $cb, $arg ]);
 }
 
-sub commit_title ($$) {
-        my ($self, $oid) = @_; # PublicInbox::Git, $sha1hex
-        my $buf = cat_file($self, $oid) or return;
-        utf8::decode($$buf);
-        ($$buf =~ /\r?\n\r?\n([^\r\n]+)\r?\n?/)[0]
-}
-
 sub extract_cmt_time {
         my ($bref, undef, undef, undef, $modified) = @_;
 
diff --git a/t/solver_git.t b/t/solver_git.t
index 7c5619a7..67ae02e6 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -38,12 +38,6 @@ $deliver_patch->('t/solve/0001-simple-mod.patch');
 my $v1_0_0_tag = 'cb7c42b1e15577ed2215356a2bf925aef59cdd8d';
 
 my $git = PublicInbox::Git->new($git_dir);
-is('public-inbox 1.0.0',
-        $git->commit_title($v1_0_0_tag),
-        'commit_title works on 1.0.0');
-
-is(undef, $git->commit_title('impossible'), 'undef on impossible object');
-
 $ibx->{-repo_objs} = [ $git ];
 my $res;
 my $solver = PublicInbox::SolverGit->new($ibx, sub { $res = $_[0] });