diff options
author | Eric Wong <e@yhbt.net> | 2020-08-28 10:12:59 +0000 |
---|---|---|
committer | Eric Wong <e@yhbt.net> | 2020-08-28 22:19:27 +0000 |
commit | 64f4a7c22d570097f316a5cbaf25b99a412bf54d (patch) | |
tree | 8532835e0223d28982db12836f6a5bac452fb92c | |
parent | b1054300d1e33cb7b2279922c8f73628551fbf8f (diff) | |
download | public-inbox-64f4a7c22d570097f316a5cbaf25b99a412bf54d.tar.gz |
By making it a no-op if last_uid is not defined. This isn't a hot code path, so the extra method dispatch isn't an issue. It'll save some indentation/wrapping in future commits.
-rw-r--r-- | lib/PublicInbox/IMAPTracker.pm | 5 | ||||
-rw-r--r-- | lib/PublicInbox/WatchMaildir.pm | 4 |
2 files changed, 5 insertions, 4 deletions
diff --git a/lib/PublicInbox/IMAPTracker.pm b/lib/PublicInbox/IMAPTracker.pm index 92f21584..be9caf76 100644 --- a/lib/PublicInbox/IMAPTracker.pm +++ b/lib/PublicInbox/IMAPTracker.pm @@ -49,13 +49,14 @@ SELECT uid_validity, uid FROM imap_last WHERE url = ? } sub update_last ($$$) { - my ($self, $validity, $last) = @_; + my ($self, $validity, $last_uid) = @_; + return unless defined $last_uid; my $sth = $self->{dbh}->prepare_cached(<<''); INSERT OR REPLACE INTO imap_last (url, uid_validity, uid) VALUES (?, ?, ?) $self->lock_acquire; - my $rv = $sth->execute($self->{url}, $validity, $last); + my $rv = $sth->execute($self->{url}, $validity, $last_uid); $self->lock_release; $rv; } diff --git a/lib/PublicInbox/WatchMaildir.pm b/lib/PublicInbox/WatchMaildir.pm index 78aec8a2..a227a6fd 100644 --- a/lib/PublicInbox/WatchMaildir.pm +++ b/lib/PublicInbox/WatchMaildir.pm @@ -494,7 +494,7 @@ sub imap_fetch_all ($$$) { last if $self->{quit}; } _done_for_now($self); - $itrk->update_last($r_uidval, $last_uid) if defined $last_uid; + $itrk->update_last($r_uidval, $last_uid); } until ($err || $self->{quit}); $err; } @@ -919,7 +919,7 @@ sub nntp_fetch_all ($$$) { $last_art = $art; } _done_for_now($self); - $itrk->update_last(0, $last_art) if defined $last_art; + $itrk->update_last(0, $last_art); $err; } |