about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2022-11-28 05:32:26 +0000
committerEric Wong <e@80x24.org>2022-11-28 23:38:59 +0000
commit61c01dc4b39fc5ba2ba85456fb4363d8f311cca5 (patch)
tree327da69db086ece2673fceda15ded00cf6902e6f
parentb3b025134c71d00fa26435aec1d2cb8c196103ac (diff)
downloadpublic-inbox-61c01dc4b39fc5ba2ba85456fb4363d8f311cca5.tar.gz
All of our curl invocations use the `-f' (--fail) switch
anyways, and I can't imagine a time when we'd want silent
failures.
-rw-r--r--lib/PublicInbox/LeiMirror.pm6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index cc5ea1d2..cf4e58f1 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -51,7 +51,7 @@ sub try_scrape {
         my $uri = URI->new($self->{src});
         my $lei = $self->{lei};
         my $curl = $self->{curl} //= PublicInbox::LeiCurl->new($lei) or return;
-        my $cmd = $curl->for_uri($lei, $uri, qw(-f --compressed));
+        my $cmd = $curl->for_uri($lei, $uri, '--compressed');
         my $opt = { 0 => $lei->{0}, 2 => $lei->{2} };
         my $fh = popen_rd($cmd, undef, $opt);
         my $html = do { local $/; <$fh> } // die "read(curl $uri): $!";
@@ -151,7 +151,7 @@ sub _get_txt_start { # non-fatal
         my $f = (split(m!/!, $endpoint))[-1];
         my $ft = File::Temp->new(TEMPLATE => "$f-XXXX", TMPDIR => 1);
         my $opt = { 0 => $lei->{0}, 1 => $lei->{1}, 2 => $lei->{2} };
-        my $cmd = $self->{curl}->for_uri($lei, $uri, qw(-f --compressed -R -o),
+        my $cmd = $self->{curl}->for_uri($lei, $uri, qw(--compressed -R -o),
                                         $ft->filename);
         do_reap($self);
         $lei->qerr("# @$cmd");
@@ -994,7 +994,7 @@ sub try_manifest {
                 delete $opt{TMPDIR};
         }
         my $ft = File::Temp->new(TEMPLATE => '.manifest-XXXX', %opt);
-        my $cmd = $curl->for_uri($lei, $uri, qw(-f -R -o), $ft->filename);
+        my $cmd = $curl->for_uri($lei, $uri, qw(-R -o), $ft->filename);
         push(@$cmd, '-z', $manifest) if -f $manifest;
         my $mf_url = "$uri";
         %opt = map { $_ => $lei->{$_} } (0..2);