about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-08-07 01:14:03 +0000
committerEric Wong <e@yhbt.net>2020-08-07 23:45:37 +0000
commit32f6a1f9498f759041b72d6f4d5cb959088a3dec (patch)
tree6cff57ee30ad41a5ca106a554b0748ad5dfba58a
parent4cbfa74212a5140bbf5d4fe74b8929215d7154a3 (diff)
downloadpublic-inbox-32f6a1f9498f759041b72d6f4d5cb959088a3dec.tar.gz
We need to drop old ghosts properly while inside the
transaction, otherwise it becomes a no-op.  This isn't a big
deal, as it only results in a few dangling DB rows and a
small amount of wasted space.
-rw-r--r--lib/PublicInbox/V2Writable.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 344edbba..f98afa61 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -1244,13 +1244,13 @@ sub index_sync {
         }
         # work forwards through history
         index_epoch($self, $sync, $_) for (0..$epoch_max);
+        $self->{over}->rethread_done($opt);
         $self->done;
 
         if (my $nr = $sync->{nr}) {
                 my $pr = $sync->{-opt}->{-progress};
                 $pr->('all.git '.sprintf($sync->{-regen_fmt}, $$nr)) if $pr;
         }
-        $self->{over}->rethread_done($opt);
 
         # reindex does not pick up new changes, so we rerun w/o it:
         if ($opt->{reindex}) {