about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-06-24 02:52:28 +0000
committerEric Wong <e@80x24.org>2019-06-24 05:26:26 +0000
commit2600289573c569fea65a1da817497414175bae55 (patch)
treec52ae67134a85aae8f2cb8edf132300a5ab112dc
parent62e3722f13164696a7af66cfa6253f69f0f5892b (diff)
downloadpublic-inbox-2600289573c569fea65a1da817497414175bae55.tar.gz
YAGNI

Followup-to: commit 30ab5cf82b9d47242640f748a0f9a088ca783e32
	("ds: reduce Errno imports and drop ->close reason")
-rw-r--r--lib/PublicInbox/HTTP.pm4
-rw-r--r--lib/PublicInbox/HTTPD/Async.pm4
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 94972054..c81aeacd 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -438,7 +438,7 @@ sub quit {
 }
 
 sub close {
-        my $self = shift;
+        my $self = $_[0];
         if (my $env = delete $self->{env}) {
                 delete $env->{'psgix.io'}; # prevent circular references
         }
@@ -447,7 +447,7 @@ sub close {
                 eval { $forward->close };
                 err($self, "forward ->close error: $@") if $@;
         }
-        $self->SUPER::close(@_);
+        $self->SUPER::close; # PublicInbox::DS::close
 }
 
 # for graceful shutdown in PublicInbox::Daemon:
diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm
index bec49337..e6df58eb 100644
--- a/lib/PublicInbox/HTTPD/Async.pm
+++ b/lib/PublicInbox/HTTPD/Async.pm
@@ -80,9 +80,9 @@ sub async_pass {
 sub event_step { $_[0]->{cb}->(@_) }
 
 sub close {
-        my $self = shift;
+        my $self = $_[0];
         delete $self->{cb};
-        $self->SUPER::close(@_);
+        $self->SUPER::close;
 
         # we defer this to the next timer loop since close is deferred
         if (my $cleanup = delete $self->{cleanup}) {