about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2022-03-30 19:53:02 +0000
committerEric Wong <e@80x24.org>2022-04-01 07:38:41 +0000
commit1e62f600af782dd8616ffd97ed3c335abca25778 (patch)
tree1559f22f529af84e52af353c77e69d8c518e79a9
parent2ea283f1f34efdcfc8b3f5136d7d436664ed6eda (diff)
downloadpublic-inbox-1e62f600af782dd8616ffd97ed3c335abca25778.tar.gz
It's less cognitive overhead for future readers since I just
looked at it again and thought it was possible for "0" to be returned
(it isn't).
-rw-r--r--lib/PublicInbox/ViewDiff.pm10
1 files changed, 5 insertions, 5 deletions
diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm
index f492b697..fb394b7c 100644
--- a/lib/PublicInbox/ViewDiff.pm
+++ b/lib/PublicInbox/ViewDiff.pm
@@ -83,7 +83,7 @@ sub anchor0 ($$$$) {
         # long filenames will require us to check in anchor1()
         push(@{$ctx->{-long_path}}, $fn) if $fn =~ s!\A\.\.\./?!!;
 
-        if (my $attr = to_attr($ctx->{-apfx}.$fn)) {
+        if (defined(my $attr = to_attr($ctx->{-apfx}.$fn))) {
                 $ctx->{-anchors}->{$attr} = 1;
                 my $spaces = ($orig =~ s/( +)\z//) ? $1 : '';
                 $$dst .= " <a\nid=i$attr\nhref=#$attr>" .
@@ -97,7 +97,7 @@ sub anchor0 ($$$$) {
 # returns "diff --git" anchor destination, undef otherwise
 sub anchor1 ($$) {
         my ($ctx, $pb) = @_;
-        my $attr = to_attr($ctx->{-apfx}.$pb) or return;
+        my $attr = to_attr($ctx->{-apfx}.$pb) // return;
 
         my $ok = delete $ctx->{-anchors}->{$attr};
 
@@ -105,10 +105,10 @@ sub anchor1 ($$) {
         # assume diffstat and diff output follow the same order,
         # and ignore different ordering (could be malicious input)
         unless ($ok) {
-                my $fn = shift(@{$ctx->{-long_path}}) or return;
+                my $fn = shift(@{$ctx->{-long_path}}) // return;
                 $pb =~ /\Q$fn\E\z/s or return;
-                $attr = to_attr($ctx->{-apfx}.$fn) or return;
-                $ok = delete $ctx->{-anchors}->{$attr} or return;
+                $attr = to_attr($ctx->{-apfx}.$fn) // return;
+                $ok = delete $ctx->{-anchors}->{$attr} // return;
         }
         $ok ? "<a\nhref=#i$attr\nid=$attr>diff</a> --git" : undef
 }