about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-05-16 07:35:02 +0000
committerEric Wong <e@yhbt.net>2020-05-16 10:06:40 +0000
commit11fcb0446a6749ce2ac582d7a1f361ec7355d2f8 (patch)
tree1ea63eeb983e8f52ff24674bed8c7c4adf76e8ca
parent0a556c99c0db5160f43931422a563c6094b64ea2 (diff)
downloadpublic-inbox-11fcb0446a6749ce2ac582d7a1f361ec7355d2f8.tar.gz
However, we'll always have a newline before subsequent
attachments links after the first.

For the initial part of a multipart message, this regression
appeared in 1.5.0, but the display was overly clumped in prior
relases, too.

Fixes: 453dee4881a9c764 ("msg_iter: pass $idx as a scalar, not array")
-rw-r--r--lib/PublicInbox/View.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index ef5f4b3a..7264f4b6 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -483,7 +483,7 @@ sub multipart_text_as_html {
 sub attach_link ($$$$;$) {
         my ($ctx, $ct, $p, $fn, $err) = @_;
         my ($part, $depth, $idx) = @$p;
-        my $nl = substr($idx, -2) eq '.1' ? '' : "\n"; # like join("\n", ...)
+        my $nl = $idx eq '1' ? '' : "\n"; # like join("\n", ...)
         my $size = bytes::length($part->body);
 
         # hide attributes normally, unless we want to aid users in