about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2014-04-11 19:51:32 +0000
committerEric Wong <e@80x24.org>2014-04-11 22:24:30 +0000
commit930fe68247cb3ec5aa304270818788b19600e9fb (patch)
tree05f1518905147a13ef6c91a524695aa999cfc0b8
parent9e98246f95c2b660c99949242251245b7bf14c45 (diff)
downloadpublic-inbox-930fe68247cb3ec5aa304270818788b19600e9fb.tar.gz
I often forget the subtleties of Perl regexps and newlines,
so I suspect others do, too.  Use explicit capture so it's
more familiar to users of non-Perl regexps.
-rw-r--r--lib/PublicInbox/Filter.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/Filter.pm b/lib/PublicInbox/Filter.pm
index e5a8fafe..bd33130c 100644
--- a/lib/PublicInbox/Filter.pm
+++ b/lib/PublicInbox/Filter.pm
@@ -93,7 +93,7 @@ sub dump_html {
         my $err = "";
 
         # be careful about remote command injection!
-        if ($charset =~ /\A[A-Za-z0-9\-]+\z/) {
+        if ($charset =~ /\A([A-Za-z0-9\-]+)\z/) {
                 push @cmd, "-assume_charset=$charset";
         }
         if (IPC::Run::run(\@cmd, $body, \$out, \$err)) {