about summary refs log tree commit
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-07-13 20:27:57 +0000
committerEric Wong <e@80x24.org>2019-07-13 21:49:40 +0000
commita090752ccc1bdbe5d90ec54dbecbb1a44f3f8091 (patch)
tree345b68f30e990c89636c2bb9a6fe46e02f4b5718
parentbb484f2ca29b10d2ae001bda77406c8b433c9e80 (diff)
downloadpublic-inbox-a090752ccc1bdbe5d90ec54dbecbb1a44f3f8091.tar.gz
nntpdeflate: stop relying on SUPER for ->do_read
We won't need further layering after enabling compression.  So
be explicit about which sub we're calling when we hit ->do_read
from NNTP and eliminate the need for the comment.
-rw-r--r--lib/PublicInbox/NNTPdeflate.pm4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/NNTPdeflate.pm b/lib/PublicInbox/NNTPdeflate.pm
index 10e2337c..f2de0f38 100644
--- a/lib/PublicInbox/NNTPdeflate.pm
+++ b/lib/PublicInbox/NNTPdeflate.pm
@@ -62,13 +62,13 @@ sub enable {
 # overrides PublicInbox::NNTP::compressed
 sub compressed { 1 }
 
-# SUPER is PublicInbox::DS::do_read, so $_[1] may be a reference or not
+# $_[1] may be a reference or not
 sub do_read ($$$$) {
         my ($self, $rbuf, $len, $off) = @_;
 
         my $zin = $self->{zin} or return; # closed
         my $deflated = \($zin->[1]);
-        my $r = $self->SUPER::do_read($deflated, $len) or return;
+        my $r = PublicInbox::DS::do_read($self, $deflated, $len) or return;
 
         # assert(length($$rbuf) == $off) as far as NNTP.pm is concerned
         # -ConsumeInput is true, so $deflated is automatically emptied