about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-01-30 07:39:02 +0000
committerEric Wong <e@80x24.org>2019-01-30 07:40:25 +0000
commita00def885e67f7da07fe64a92b6fd306d5011d45 (patch)
tree426b84247c8cf7925ba03f2b97a2316ee8980405
parentb8eb1f39dc9aea6ce84373c50c47c6fc4ac8c503 (diff)
downloadpublic-inbox-a00def885e67f7da07fe64a92b6fd306d5011d45.tar.gz
Removing 'psgix.input.buffered' could be a possibility in
the future.
-rw-r--r--lib/PublicInbox/HTTPD.pm9
1 files changed, 8 insertions, 1 deletions
diff --git a/lib/PublicInbox/HTTPD.pm b/lib/PublicInbox/HTTPD.pm
index 38517710..b0bf94ad 100644
--- a/lib/PublicInbox/HTTPD.pm
+++ b/lib/PublicInbox/HTTPD.pm
@@ -29,9 +29,16 @@ sub new {
                 'psgi.run_once'         => Plack::Util::FALSE,
                 'psgi.multithread' => Plack::Util::FALSE,
                 'psgi.multiprocess' => Plack::Util::TRUE,
+
+                # We don't use this anywhere, but we can support
+                # other PSGI apps which might use it:
                 'psgix.input.buffered' => Plack::Util::TRUE,
 
-                # XXX unstable API!
+                # XXX unstable API!, only GitHTTPBackend needs
+                # this to limit git-http-backend(1) parallelism.
+                # The rest of our PSGI code is generic, relying
+                # on "pull" model using "getline" to prevent
+                # over-buffering.
                 'pi-httpd.async' => do {
                         no warnings 'once';
                         *pi_httpd_async