about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-02-01 06:30:17 +0000
committerEric Wong <e@80x24.org>2019-02-01 07:40:15 +0000
commit3ccdbd75b0e337c393e53db0288e72b6e65ab9e0 (patch)
tree3c603752225234bb53f36e8412882fb7cf9c4860
parentf8d9d0b2befb11597890e5ef2ea5ee7cc1d49581 (diff)
downloadpublic-inbox-3ccdbd75b0e337c393e53db0288e72b6e65ab9e0.tar.gz
For URLs we generate, we need to escape '&' in query parameters
for correctness.
-rw-r--r--lib/PublicInbox/ViewDiff.pm4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm
index 2074e12f..fbdc5b95 100644
--- a/lib/PublicInbox/ViewDiff.pm
+++ b/lib/PublicInbox/ViewDiff.pm
@@ -133,8 +133,8 @@ sub flush_diff ($$$) {
                                         Q => "?b=".uri_escape_utf8($pb, UNSAFE),
                                 };
                                 if ($pa ne $pb) {
-                                        $dctx->{Q} .=
-                                             "&a=".uri_escape_utf8($pa, UNSAFE);
+                                        $dctx->{Q} .= '&amp;a='.
+                                                uri_escape_utf8($pa, UNSAFE);
                                 }
                                 anchor1($dst, $ctx, $linkify, $pb, $s) and next;
                         }