diff options
| author | Eric Wong <e@80x24.org> | 2016-05-28 01:57:09 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2016-05-28 01:57:35 +0000 |
| commit | 17577bf82166f4967bb66cb120fc42ce5448fe54 (patch) | |
| tree | 18b779cf5a27ade7c180c1a4de0375eb005103cb | |
| parent | 589199dcfebcb96ab77fff6043ecb142b948f824 (diff) | |
| download | public-inbox-17577bf82166f4967bb66cb120fc42ce5448fe54.tar.gz | |
It's a low priority, but acknowledge it.
| -rw-r--r-- | lib/PublicInbox/HTTP.pm | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index 0454f607..fcbd758a 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -4,7 +4,7 @@ # Generic PSGI server for convenience. It aims to provide # a consistent experience for public-inbox admins so they don't have # to learn different ways to admin both NNTP and HTTP components. -# There's nothing public-inbox-specific, here. +# There's nothing which depends on public-inbox, here. # Each instance of this class represents a HTTP client socket package PublicInbox::HTTP; @@ -25,7 +25,7 @@ use constant { CHUNK_MAX_HDR => 256, }; -# FIXME: duplicated code with NNTP.pm +# FIXME: duplicated code with NNTP.pm, layering violation my $WEAKEN = {}; # string(inbox) -> inbox my $weakt; sub weaken_task () { @@ -249,6 +249,8 @@ sub response_done ($$) { $self->{env} = undef; $self->write("0\r\n\r\n") if $alive == 2; $self->write(sub { $alive ? next_request($self) : $self->close }); + + # FIXME: layering violation if (my $obj = $env->{'pi-httpd.inbox'}) { # grace period for reaping resources $WEAKEN->{"$obj"} = $obj; |