user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <e@80x24.org>
Cc: "René Scharfe" <l.s.r@web.de>,
	git@vger.kernel.org, meta@public-inbox.org
Subject: Re: `git patch-id --stable' vs quoted-printable
Date: Sun, 21 Aug 2022 21:18:26 -0700	[thread overview]
Message-ID: <xmqq7d30gbcd.fsf@gitster.g> (raw)
In-Reply-To: <xmqqczcsgbvn.fsf@gitster.g> (Junio C. Hamano's message of "Sun, 21 Aug 2022 21:06:52 -0700")

Junio C Hamano <gitster@pobox.com> writes:

>> So, I'm wondering if the search indexing code of public-inbox
>> should s/^$/ /mgs before feeding stuff to `git patch-id'; and/or
>> if `git patch-id' should be assuming empty lines and lines with a
>> single SP are the same...

Another potential source of issues (not for the patch from René that
was used as an example) is that a patch producer can use different
diff algorithm from the setting you would use to index resulting
commits via "git show | git patch-id".

    $ git show -U5 | git patch-id
    $ git show | git patch-id

likely result in different patch IDs.  

The --patience and the --histogram options affect how common lines
are matched up, again affecting the shape of the patches you compute
patch-ids over.

  reply	other threads:[~2022-08-22  4:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22  2:25 `git patch-id --stable' vs quoted-printable Eric Wong
2022-08-22  4:06 ` Junio C Hamano
2022-08-22  4:18   ` Junio C Hamano [this message]
2022-08-22  4:57     ` Eric Wong
2022-08-22 15:58   ` René Scharfe
2022-08-22 16:21     ` Junio C Hamano
2022-08-22 17:01       ` Eric Wong
2022-08-22 18:25         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7d30gbcd.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).