From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B4BA71F59D for ; Sun, 15 Jan 2023 11:43:53 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=i5DCrzrT; dkim-atps=neutral Received: by mail-wm1-x32e.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so608299wmb.0 for ; Sun, 15 Jan 2023 03:43:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5jgeU1DmDtqFRTtMQiCTrzr14TFbDyEa5XKrt9dWXso=; b=i5DCrzrTwRDo8lOAMKcSy2h94O+HV0RErR7gY9q0+fP3TMSxzRoRVsM2VAhjXokWR0 oB7VKaNacCyJqS3oy30mH6CzH7hBOBx6tXQmYqAkX154dueyKKdT+PEFhDt7Fylw1H1O QzX46Vi1QRM6mvsgU4gzUKTYhlleUxWFwXkVgbYFcUZVfSvwNOk3qIA/8fi4eybJ4c/O W4oi2EJ8LpxpJZO4MVRsyvcCPTJFiMblRUdKv2rcjziVR/hlBsq/ynD/wljgIQkFRO0f /agiJKFS7IVKok7AJE3tOGnta3dYXofjTkxBDaL0U19yaqTkdjtj776BE7Lg8UryXgUb MQng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5jgeU1DmDtqFRTtMQiCTrzr14TFbDyEa5XKrt9dWXso=; b=gBStz0oQeopxt9PZGn1RhxAL+sO4P6CFThpj6E3SKOXxoUCgjs0OeXwAM2KVBSl45I xQ+2ezXpk4euOM1nClv1Qjqb7qNS99Xq0EncnHYk1Mahp2iRlPwaNu3MQD3KDTDFzu7k DQ30HoVEJSXgwTyro/lfpYJxGTsZJDtJe94FiE+7nTFSTVFNvEUX4Cw88+gZiDUrwvfj 3ZjB3TQeh9rxmDk/ePFEfvkbMB4P9lQ4ictlmIRZtvyeq1TotZPsa4eh7lHpU1go+kxJ BEw/eATyJ0PD8LNhcucTZ0Hbzx+ZOrKpWeGkpAGUeGq6DmO0WHasdbZ2vt535DR5zYTd yXsQ== X-Gm-Message-State: AFqh2kqkllAq8EhOYbu2jhsp2SX69vgm76m4rkOg48HoyI8Yoa/K56ct hRqAlR3tuslfqli4jfMkjJJUPdEno8m+Dlha X-Google-Smtp-Source: AMrXdXsFoIz47stJEfT0X08O0tJOaMiVTIg1HsKnwrizs5OGhtivH+vArWz/JvdesCe8oEZW9d0bgQ== X-Received: by 2002:a05:600c:19c7:b0:3d9:7096:262a with SMTP id u7-20020a05600c19c700b003d97096262amr58110345wmq.27.1673783031209; Sun, 15 Jan 2023 03:43:51 -0800 (PST) Received: from [10.19.18.56] ([212.102.57.84]) by smtp.gmail.com with ESMTPSA id d8-20020a05600c34c800b003c5571c27a1sm36897434wmq.32.2023.01.15.03.43.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Jan 2023 03:43:50 -0800 (PST) Message-ID: Date: Sun, 15 Jan 2023 12:43:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Accesskeys for keyboard navigation To: Eric Wong Cc: meta@public-inbox.org References: <20230113005752.M69467@dcvr> Content-Language: en-US From: Andrei Rybak In-Reply-To: <20230113005752.M69467@dcvr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 13/01/2023 01:57, Eric Wong wrote: > Andrei Rybak wrote: >> I'm a frequent user of accesskeys [1] so I've written a user script [2] >> to add them to some links on websites running public-inbox. The user >> script is available via Greasy Fork, a website for hosting user scripts: >> >> https://greasyfork.org/en/scripts/458141-accesskeys-for-public-inbox > > Cool. I've long intended for the HTML output to be stable > enough something like that. > > Please feel welcome post here if there's new developments or > discussion to be had about it. > > Fwiw, there's also rel=prev / rel=next for paginated pages; > but I forgot how browsers use them :x As far as I know, rel attribute has more to do with search engine optimization. However, having these attributes does make finding the links with document.querySelector much easier for my script. I've added navigation for next/prev pages to the script. > >> Any feedback, especially ideas for other uses of accesskey on >> public-inbox websites would be appreciated. > > Do you know if there's commonly-used accesskeys for normal git repo > viewers? (cgit/gitweb/etc...) None that I know of, and I would guess that it isn't present in any of them, really. Confluence (wiki from Atlassian) has them, but Bitbucket (Git hosting from Atlassian) does not. (Side note: both of them also implement their own custom shortcuts). > The /$INBOX/$OID/s/ endpoint (linked from @@ diff hunk headers) > is being extended to support "normal" git repositories meant for > code (WIP: https://80x24.org/lore/pub/scm/git/git.git/ ) and > I'd like to avoid conflicts. Conflicts won't be a problem, because there wouldn't be a lot of users of the user script. I'll just adjust my script, if needed. >> P.S. I've looked at source code of public-inbox to try adding support for >> accesskeys natively, but my Perl knowledge is very limited, so I >> decided against trying to implement it on my own for a patch. > > No worries. I will consider it if I find time (some other things > take priority atm). > > Do you happen to know what happens if a page defines accesskeys > which conflict with userscripts? I prefer avoiding breakage for > existing userscript users if implemented in public-inbox itself. When there is a conflict, Firefox, as an example, just shows the user every link with the same accesskey, as if the user was navigating over them using TAB key. > I am a bit hesitant to recommend browser extensions in the > documentation/help output itself since Stylish was found to be > spyware in the past. (that goes for downloading and running > anything from the Internet w/o auditing it, first, public-inbox > included) Yeah, the Stylish debacle wasn't pleasant.