user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] solver_git: support non-master git default branch
Date: Wed, 27 Oct 2021 06:59:31 +0200	[thread overview]
Message-ID: <aac7d171-c693-40cf-89f4-c0fd956767b5@t-8ch.de> (raw)
In-Reply-To: <20211027042033.GB18609@dcvr>

On 2021-10-27 04:20+0000, Eric Wong wrote:
> Thomas Weißschuh <thomas@t-8ch.de> wrote:
> > diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm
> > index 5d5060f4..f9ce3793 100644
> > --- a/lib/PublicInbox/SolverGit.pm
> > +++ b/lib/PublicInbox/SolverGit.pm
> > @@ -18,6 +18,7 @@ use PublicInbox::Qspawn;
> >  use PublicInbox::Tmpfile;
> >  use PublicInbox::GitAsyncCat;
> >  use PublicInbox::Eml;
> > +use PublicInbox::Import;
> 
> I'm hesitant to add PublicInbox::Import to code used in
> read-only daemons.
> 
> > @@ -304,7 +306,7 @@ EOF
> >  	close $fh or die "close git/config: $!";
> >  
> >  	open $fh, '>', "$git_dir/HEAD" or die "open git/HEAD: $!";
> > -	print $fh "ref: refs/heads/master\n" or die "print git/HEAD: $!";
> > +	print $fh "ref: $default_branch\n" or die "print git/HEAD: $!";
> 
> Having a global init.defaultBranch set doesn't seem to affect
> SolverGit at all, and everything in solver repos is short-lived.

Yesterday I thought this was necessary to get one of the unittests to pass.
As you can not confirm it and I can't neither today it seems to have been an
error on my part.

Let's drop this patch.

> Replacing "master" with "s" might be an option for saving a
> teeny bit of memory traffic, here. *shrug*

      reply	other threads:[~2021-10-27  4:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 22:13 [PATCH] solver_git: support non-master git default branch Thomas Weißschuh
2021-10-27  4:20 ` Eric Wong
2021-10-27  4:59   ` Thomas Weißschuh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aac7d171-c693-40cf-89f4-c0fd956767b5@t-8ch.de \
    --to=thomas@t-8ch.de \
    --cc=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).