user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Mark Wielaard <>
To: Overseers mailing list <>
Cc: Eric Wong <>,
Subject: Re: Using plus (+) in list name
Date: Sun, 21 Aug 2022 23:43:48 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20220821205338.M316466@dcvr>

Hi Eric,

On Sun, Aug 21, 2022 at 08:53:38PM +0000, Eric Wong via Overseers wrote:
> Mark Wielaard <> wrote:
> > We are setting up a public-inbox instance for cygwin/gcc/sourceware
> > lists at and it seems to work pretty
> > nicely. Thanks. Except for lists which have a + in their name like
> > libstdc++.
> > 
> > I assume this needs some escaping somewhere, but I cannot figure out
> > where. The .public-inbox/config snippet looks like:
> I seem to remember '+' is OK as-is in the path component of HTTP URLs,
> but is escaping for ' ' (SP) in query strings.

Yes, '+' doesn't have a reserved purpose in the path component, but
does encode a space in the query string. So it doesn't have to be
escaped in the path component and can be used as is (although
percentage encoding is recommended nobody seems to do it).

> > This seems to work fine for nntp and imap, but not https.
> Interesting that NNTP and IMAP work (I wasn't expecting it :x).
> I can't remember off the top of my head, but is '+' allowed by
> the relevant NNTP and List-Id RFCs?

I don't know. I just observed that I can see the group name
inbox.gcc.libstdc++ in my nttp and imap readers when pointing at

> > We are using the EPEL public-inbox package public-inbox-1.7.0-2.el8.noarch
> Totally untested, but perhaps changing $INBOX_RE in
> PublicInbox/ will work:
> diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
> index b9b68382..77f463d3 100644
> --- a/lib/PublicInbox/
> +++ b/lib/PublicInbox/
> @@ -23,7 +23,7 @@ use PublicInbox::WwwStatic qw(r path_info_raw);
>  use PublicInbox::Eml;
>  # TODO: consider a routing tree now that we have more endpoints:
> -our $INBOX_RE = qr!\A/([\w\-][\w\.\-]*)!;
> +our $INBOX_RE = qr!\A/([\w\-][\w\.\-\+]*)!;
>  our $MID_RE = qr!([^/]+)!;
>  our $END_RE = qr!(T/|t/|t\.mbox(?:\.gz)?|t\.atom|raw|)!;
>  our $ATTACH_RE = qr!([0-9][0-9\.]*)-($PublicInbox::Hval::FN)!;

That works! looks fully
functional now.

Now to figure out how to properly include that patch before the other
sourceware overseers figure out I patched the packaged code in place.



  reply	other threads:[~2022-08-21 21:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-21 20:02 Using plus (+) in list name Mark Wielaard
2022-08-21 20:53 ` Eric Wong
2022-08-21 21:43   ` Mark Wielaard [this message]
2022-08-21 22:11     ` Eric Wong
2022-08-21 22:21       ` [PATCH] www: support `+' in inbox names Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).