Re: [PATCH] nodatacow: quiet chattr errors [was: Test failures with 1.7.0]

[Dominique Martinet <asmadeus@codewreck.org>]

Dominique Martinet wrote on Thu, Dec 09, 2021 at 06:14:36AM +0900:
> I'll try giving it one, in my opinion it's more representative to test
> with inline-c working.

So giving tests a home appear to make another test hang
(t/lei-refresh-mail-sync.t)

I've run out of time, will provide more traces tonight

> > Yes on tests requiring stderr to be empty.  Below is a patch
> > which should fix it; however it should only be calling chattr on
> > btrfs mounts.
> 
> I'll give this a try as well.

This patch makes the tests pass as expected.

> > You can also try:
> > 
> >   BTRFS_TESTDIR=/path/to/your/btrfs-mount prove -bvw t/nodatacow.t
> 
> I'll try something similar as well.

I can confirm this one works as well after installing chattr and running
on btrfs, so there's no problem if mounts parsing is fixed.

I'd say this hints at a problem so we're probably better off not
silencing chattr warnings, but would also need to check if the chattr
binary is present... Probably not worth the hassle, I don't know.


> It turns out the other people with failing test are both using zfs, so
> the last problem might be somewhat related; I'll give that a try too.

Julien could also reproduce this one by running on ZFS, we'll provide
more traces when we have them!
-- 
Dominique