user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] {dir,inbox}idle: use level-triggered epoll
@ 2021-10-04  8:26 Eric Wong
  2021-10-04  9:55 ` Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2021-10-04  8:26 UTC (permalink / raw)
  To: meta

Both read(2) on inotify and kevent(2) have a finite amount of
This can prevent missed/delayed notifications while still
ensuring fairness in busy event loops.
---
 lib/PublicInbox/DirIdle.pm   | 4 ++--
 lib/PublicInbox/InboxIdle.pm | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/DirIdle.pm b/lib/PublicInbox/DirIdle.pm
index d572c2749f7f..c9a293e9355a 100644
--- a/lib/PublicInbox/DirIdle.pm
+++ b/lib/PublicInbox/DirIdle.pm
@@ -5,7 +5,7 @@
 package PublicInbox::DirIdle;
 use strict;
 use parent 'PublicInbox::DS';
-use PublicInbox::Syscall qw(EPOLLIN EPOLLET);
+use PublicInbox::Syscall qw(EPOLLIN);
 use PublicInbox::In2Tie;
 
 my ($MAIL_IN, $MAIL_GONE, $ino_cls);
@@ -38,7 +38,7 @@ sub new {
 	if ($ino_cls) {
 		$inot = $ino_cls->new or die "E: $ino_cls->new: $!";
 		my $io = PublicInbox::In2Tie::io($inot);
-		$self->SUPER::new($io, EPOLLIN | EPOLLET);
+		$self->SUPER::new($io, EPOLLIN);
 	} else {
 		require PublicInbox::FakeInotify;
 		$inot = PublicInbox::FakeInotify->new; # starts timer
diff --git a/lib/PublicInbox/InboxIdle.pm b/lib/PublicInbox/InboxIdle.pm
index 4d74b3545902..2781b3e15bb9 100644
--- a/lib/PublicInbox/InboxIdle.pm
+++ b/lib/PublicInbox/InboxIdle.pm
@@ -7,7 +7,7 @@
 package PublicInbox::InboxIdle;
 use strict;
 use parent qw(PublicInbox::DS);
-use PublicInbox::Syscall qw(EPOLLIN EPOLLET);
+use PublicInbox::Syscall qw(EPOLLIN);
 my $IN_MODIFY = 0x02; # match Linux inotify
 my $ino_cls;
 if ($^O eq 'linux' && eval { require Linux::Inotify2; 1 }) {
@@ -73,7 +73,7 @@ sub new {
 	if ($ino_cls) {
 		$inot = $ino_cls->new or die "E: $ino_cls->new: $!";
 		my $io = PublicInbox::In2Tie::io($inot);
-		$self->SUPER::new($io, EPOLLIN | EPOLLET);
+		$self->SUPER::new($io, EPOLLIN);
 	} else {
 		require PublicInbox::FakeInotify;
 		$inot = PublicInbox::FakeInotify->new;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] {dir,inbox}idle: use level-triggered epoll
  2021-10-04  8:26 [PATCH] {dir,inbox}idle: use level-triggered epoll Eric Wong
@ 2021-10-04  9:55 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2021-10-04  9:55 UTC (permalink / raw)
  To: meta

Eric Wong <e@80x24.org> wrote:
> Both read(2) on inotify and kevent(2) have a finite amount of

    events.  Let the kernel notify us again in cases where we'd
    need to retry instead of looping ourselves.

My brain is still experiencing packet loss :x

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-04  9:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04  8:26 [PATCH] {dir,inbox}idle: use level-triggered epoll Eric Wong
2021-10-04  9:55 ` Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).