user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] Gcf2: Create cache folder if missing
@ 2022-09-08 19:57 Ricardo Ribalda
  2022-09-08 22:08 ` Eric Wong
  0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Ribalda @ 2022-09-08 19:57 UTC (permalink / raw)
  To: meta; +Cc: Ricardo Ribalda

The code expects that the folder is already present, this patch creates
it if missing.

Without this path the test fails with:

open(/home/debci/.cache/public-inbox/inline-c/.public-inbox.lock): No such file or directory at /usr/share/perl5/PublicInbox/Gcf2.pm line 20

Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
---
 lib/PublicInbox/Gcf2.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/PublicInbox/Gcf2.pm b/lib/PublicInbox/Gcf2.pm
index 41ee0715..02cd0de2 100644
--- a/lib/PublicInbox/Gcf2.pm
+++ b/lib/PublicInbox/Gcf2.pm
@@ -10,12 +10,14 @@ use PublicInbox::Spawn qw(which popen_rd); # may set PERL_INLINE_DIRECTORY
 use Fcntl qw(LOCK_EX SEEK_SET);
 use Time::HiRes qw(clock_gettime CLOCK_MONOTONIC);
 use IO::Handle; # autoflush
+use File::Path qw(make_path);
 BEGIN {
 	my (%CFG, $c_src);
 	# PublicInbox::Spawn will set PERL_INLINE_DIRECTORY
 	# to ~/.cache/public-inbox/inline-c if it exists
 	my $inline_dir = $ENV{PERL_INLINE_DIRECTORY} //
 		die 'PERL_INLINE_DIRECTORY not defined';
+	make_path($inline_dir);
 	my $f = "$inline_dir/.public-inbox.lock";
 	open my $fh, '+>', $f or die "open($f): $!";
 
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Gcf2: Create cache folder if missing
  2022-09-08 19:57 [PATCH] Gcf2: Create cache folder if missing Ricardo Ribalda
@ 2022-09-08 22:08 ` Eric Wong
  2022-09-09 10:10   ` Ricardo Ribalda Delgado
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Wong @ 2022-09-08 22:08 UTC (permalink / raw)
  To: Ricardo Ribalda; +Cc: meta

Applied as commit ad8acf7d6484d0a489499742cadadbd4f890ab53
Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Gcf2: Create cache folder if missing
  2022-09-08 22:08 ` Eric Wong
@ 2022-09-09 10:10   ` Ricardo Ribalda Delgado
  0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2022-09-09 10:10 UTC (permalink / raw)
  To: Eric Wong; +Cc: meta

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

Thanks!

On Fri, Sep 9, 2022 at 12:09 AM Eric Wong <e@80x24.org> wrote:

> Applied as commit ad8acf7d6484d0a489499742cadadbd4f890ab53
> Thanks.
>

[-- Attachment #2: Type: text/html, Size: 421 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-09 10:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-08 19:57 [PATCH] Gcf2: Create cache folder if missing Ricardo Ribalda
2022-09-08 22:08 ` Eric Wong
2022-09-09 10:10   ` Ricardo Ribalda Delgado

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).