From: Rob Herring <firstname.lastname@example.org> To: Eric Wong <email@example.com> Cc: Konstantin Ryabitsev <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH] searchidx: index "diff --git a/... b/..." headers Date: Mon, 8 Nov 2021 18:38:25 -0600 [thread overview] Message-ID: <CAL_Jsq+aqDmpxUHsw844xS8f6WRX3gcvt7GQhf2XB7-Lb=Yx8Q@mail.gmail.com> (raw) In-Reply-To: <20211108212714.GA13642@dcvr> On Mon, Nov 8, 2021 at 3:27 PM Eric Wong <firstname.lastname@example.org> wrote: > > Rob Herring <email@example.com> wrote: > > On Mon, Nov 8, 2021 at 2:22 PM Konstantin Ryabitsev > > > I think 's:patch AND nq:diff' is a good option here. > > > > Not even close really. That mainly finds my replies with 'diff' in > > them. I'm not sure why, but it misses most actual patches: > > > > https://lore.kernel.org/all/?q=s%3Apatch+nq%3Adiff+f%3Arobh%40kernel.org > > Actually, it looks like nq:diff never works. The diff indexer > skips right over 'diff --git a/... b/...' lines :x Never works for 'diff' being a patch? Because it works very well finding all the other cases. > The following should fix it, but reindexing is necessary. > ---------8<---------- > Subject: [PATCH] searchidx: index "diff --git a/... b/..." headers > > While we do detailed indexing of git diffs, the header itself > was failing and queries like 'nq:diff' would not work. Any thoughts on supporting an 'is a patch' type query? Rob
next prev parent reply other threads:[~2021-11-09 0:38 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <firstname.lastname@example.org> [not found] ` <CAL_JsqJBh1O3H2-P07AHzVq0x89BoP_N6P=rT5up6=3QyF_B0Q@mail.gmail.com> 2021-11-08 20:22 ` lei: incorrect quoting on saved searches (was Re: lore+lei: getting started) Konstantin Ryabitsev 2021-11-08 20:49 ` Eric Wong 2021-11-08 21:36 ` Konstantin Ryabitsev 2021-11-08 21:48 ` Eric Wong 2021-11-08 22:36 ` Konstantin Ryabitsev 2021-11-08 22:57 ` Eric Wong 2021-11-08 20:53 ` Rob Herring 2021-11-08 21:27 ` [PATCH] searchidx: index "diff --git a/... b/..." headers Eric Wong 2021-11-09 0:38 ` Rob Herring [this message] 2021-11-09 3:12 ` Eric Wong 2021-11-09 4:03 ` Rob Herring 2021-11-09 5:08 ` Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_Jsq+aqDmpxUHsw844xS8f6WRX3gcvt7GQhf2XB7-Lb=Yx8Q@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] searchidx: index "diff --git a/... b/..." headers' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).