* [PATCH] view: handle the topic-free case properly
@ 2020-04-03 5:06 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-04-03 5:06 UTC (permalink / raw)
To: meta
There may be no topics for a given timestamp range,
so don't attempt to treat `undef' as an arrayref.
---
lib/PublicInbox/View.pm | 2 +-
t/psgi_v2.t | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 89174296..c42654b6 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1056,7 +1056,7 @@ sub acc_topic { # walk_thread callback
sub dump_topics {
my ($ctx) = @_;
my $order = delete $ctx->{order}; # [ ds, subj1, subj2, subj3, ... ]
- if (!@$order) {
+ unless ($order) {
$ctx->{-html_tip} = '<pre>[No topics in range]</pre>';
return 404;
}
diff --git a/t/psgi_v2.t b/t/psgi_v2.t
index 2c9387a4..c4f80869 100644
--- a/t/psgi_v2.t
+++ b/t/psgi_v2.t
@@ -250,6 +250,8 @@ test_psgi(sub { $www->call(@_) }, sub {
is($old->content, 'old', 'got expected old content');
is($new->content, 'new', 'got expected new content');
}
+ $res = $cb->(GET('/v2test/?t=1970'.'01'.'01'.'000000'));
+ is($res->code, 404, '404 for out-of-range t= param');
});
done_testing();
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-04-03 5:06 7% [PATCH] view: handle the topic-free case properly Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).