* [PATCH 10/12] nntp: some minor golfing
2020-11-27 9:52 6% [PATCH 00/12] some NNTP-related fixes + speedups Eric Wong
@ 2020-11-27 9:52 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-11-27 9:52 UTC (permalink / raw)
To: meta
Reduce screen real estate usage to reduce human attention span
requirements.
---
lib/PublicInbox/NNTP.pm | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index af40b86d..967a36a5 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -92,8 +92,7 @@ sub process_line ($$) {
err($self, 'error from: %s (%s)', $l, $err);
$res = '503 program fault - command not performed';
}
- return 0 unless defined $res;
- res($self, $res);
+ defined($res) ? res($self, $res) : 0;
}
# The keyword argument is not used (rfc3977 5.2.2)
@@ -109,9 +108,7 @@ sub cmd_capabilities ($;$) {
sub cmd_mode ($$) {
my ($self, $arg) = @_;
- $arg = uc $arg;
- return r501 unless $arg eq 'READER';
- '201 Posting prohibited';
+ uc($arg) eq 'READER' ? '201 Posting prohibited' : r501;
}
sub cmd_slave ($) { '202 slave status noted' }
^ permalink raw reply related [relevance 7%]
* [PATCH 00/12] some NNTP-related fixes + speedups
@ 2020-11-27 9:52 6% Eric Wong
2020-11-27 9:52 7% ` [PATCH 10/12] nntp: some minor golfing Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-11-27 9:52 UTC (permalink / raw)
To: meta
A few minor bugfixes and some major speedups for targeting
thousands/millions of inboxes based on stuff learned during
IMAP server development.
[PATCH 6/12] "miscsearch: implement ->newsgroup_matches"
may not be necessary, after all, but maybe it could also
be used for WWW.
Still a lot more to do...
Eric Wong (12):
nntp: use Inbox->uidvalidity instead of ->mm->created_at
nntpd: share {groups} hash with {-by_newsgroup} in Config
mm: min/max: return 0 instead of undef
nntp: use grep operation for wildmat matching
nntp: NEWNEWS: speed up filtering
miscsearch: implement ->newsgroup_matches
nntp: LIST ACTIVE.TIMES use angle brackets around address
nntp: move LIST iterators to long_response
t/extsearch: show a more realistic case
nntp: some minor golfing
nntp: xref: simplify sub signature
nntp: xref: use ->ALL extindex if available
lib/PublicInbox/Config.pm | 4 +-
lib/PublicInbox/ExtSearch.pm | 56 ++++++++++
lib/PublicInbox/IMAPD.pm | 2 +-
lib/PublicInbox/MiscSearch.pm | 40 +++++++
lib/PublicInbox/Msgmap.pm | 7 +-
lib/PublicInbox/NNTP.pm | 200 +++++++++++++++++++---------------
lib/PublicInbox/NNTPD.pm | 25 +++--
lib/PublicInbox/OverIdx.pm | 5 +
lib/PublicInbox/V2Writable.pm | 4 +-
t/extsearch.t | 54 ++++++++-
t/msgmap.t | 2 +-
t/nntp.t | 7 +-
12 files changed, 291 insertions(+), 115 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-11-27 9:52 6% [PATCH 00/12] some NNTP-related fixes + speedups Eric Wong
2020-11-27 9:52 7% ` [PATCH 10/12] nntp: some minor golfing Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).