* [PATCH 01/11] xt/solver: test with public-inbox-httpd, too
2020-09-09 6:26 5% [PATCH 00/11] httpd: further reduce event loop monopolization Eric Wong
@ 2020-09-09 6:26 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-09-09 6:26 UTC (permalink / raw)
To: meta
We'll be making changes to solver to make it even fairer
to slow clients on slow storage. Ensure we test with
public-inbox-httpd-specific codepaths, since the generic
PSGI code paths are rare in production use.
---
xt/solver.t | 31 +++++++++++++++++++++++++------
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/xt/solver.t b/xt/solver.t
index d2206b28..99fca0d3 100644
--- a/xt/solver.t
+++ b/xt/solver.t
@@ -33,11 +33,11 @@ my $todo = {
],
};
-my ($ibx, $urls);
+my ($ibx_name, $urls, @gone);
my $client = sub {
my ($cb) = @_;
for (@$urls) {
- my $url = "/$ibx/$_";
+ my $url = "/$ibx_name/$_";
my $res = $cb->(GET($url));
is($res->code, 200, $url);
next if $res->code == 200;
@@ -46,14 +46,33 @@ my $client = sub {
}
};
-while (($ibx, $urls) = each %$todo) {
+my $nr = 0;
+while (($ibx_name, $urls) = each %$todo) {
SKIP: {
- if (!$cfg->lookup_name($ibx)) {
- skip("$ibx not configured", scalar(@$urls));
+ if (!$cfg->lookup_name($ibx_name)) {
+ push @gone, $ibx_name;
+ skip("$ibx_name not configured", scalar(@$urls));
}
test_psgi($app, $client);
+ $nr++;
+ }
+}
+
+SKIP: {
+ require_mods(qw(Plack::Test::ExternalServer), $nr);
+ delete @$todo{@gone};
+
+ my $sock = tcp_server() or BAIL_OUT $!;
+ my ($tmpdir, $for_destroy) = tmpdir();
+ my ($out, $err) = map { "$tmpdir/std$_.log" } qw(out err);
+ my $cmd = [ qw(-httpd -W0), "--stdout=$out", "--stderr=$err" ];
+ my $td = start_script($cmd, undef, { 3 => $sock });
+ my ($h, $p) = ($sock->sockhost, $sock->sockport);
+
+ local $ENV{PLACK_TEST_EXTERNALSERVER_URI} = "http://$h:$p";
+ while (($ibx_name, $urls) = each %$todo) {
+ Plack::Test::ExternalServer::test_psgi(client => $client);
}
}
done_testing();
-1;
^ permalink raw reply related [relevance 7%]
* [PATCH 00/11] httpd: further reduce event loop monopolization
@ 2020-09-09 6:26 5% Eric Wong
2020-09-09 6:26 7% ` [PATCH 01/11] xt/solver: test with public-inbox-httpd, too Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-09-09 6:26 UTC (permalink / raw)
To: meta
A couple more things to mitigate the effects of slow storage
with many inboxes. Mostly solver-related, and still more to
come... (Hoping the electrical grid stays up and dust bunny
removal solved overheating problems).
Eric Wong (11):
xt/solver: test with public-inbox-httpd, too
solver: drop warnings, modernize use v5.10.1, use SEEK_SET
use "\&" where possible when referring to subroutines
www: manifest.js.gz generation no longer hogs event loop
config: flatten each_inbox and iterate_start args
config: split out iterator into separate object
t/cgi.t: show stderr on failures
extmsg: prevent cross-inbox matches from hogging event loop
wwwlisting: avoid hogging event loop
solver: check one git coderepo and inbox at a time
solver: break apart inbox blob retrieval
MANIFEST | 2 +
lib/PublicInbox/Cgit.pm | 5 +-
lib/PublicInbox/Config.pm | 22 +--
lib/PublicInbox/ConfigIter.pm | 40 +++++
lib/PublicInbox/ExtMsg.pm | 102 ++++++++----
lib/PublicInbox/IMAPD.pm | 6 +-
lib/PublicInbox/Inbox.pm | 2 +-
lib/PublicInbox/ManifestJsGz.pm | 135 ++++++++++++++++
lib/PublicInbox/SolverGit.pm | 190 +++++++++++++---------
lib/PublicInbox/TestCommon.pm | 4 +-
lib/PublicInbox/WWW.pm | 21 +--
lib/PublicInbox/Watch.pm | 13 +-
lib/PublicInbox/WwwListing.pm | 279 ++++++++------------------------
t/cgi.t | 2 +-
t/replace.t | 8 +-
t/solver_git.t | 7 +-
t/www_listing.t | 7 +-
xt/msgtime_cmp.t | 2 +-
xt/solver.t | 31 +++-
19 files changed, 499 insertions(+), 379 deletions(-)
create mode 100644 lib/PublicInbox/ConfigIter.pm
create mode 100644 lib/PublicInbox/ManifestJsGz.pm
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-09-09 6:26 5% [PATCH 00/11] httpd: further reduce event loop monopolization Eric Wong
2020-09-09 6:26 7% ` [PATCH 01/11] xt/solver: test with public-inbox-httpd, too Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).