* [PATCH 09/10] xt/eml_check_limits: remove useless import
2023-10-27 22:21 6% [PATCH 00/10] first steps towards eliminating TIEHANDLE Eric Wong
@ 2023-10-27 22:21 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-10-27 22:21 UTC (permalink / raw)
To: meta
Found while hunting for popen_rd calls.
---
xt/eml_check_limits.t | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/xt/eml_check_limits.t b/xt/eml_check_limits.t
index a6d010af..1f89c6d4 100644
--- a/xt/eml_check_limits.t
+++ b/xt/eml_check_limits.t
@@ -1,15 +1,13 @@
#!perl -w
-# Copyright (C) 2020-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
use strict;
use v5.10.1;
-use Test::More;
use PublicInbox::TestCommon;
use PublicInbox::Eml;
use PublicInbox::Inbox;
use List::Util qw(max);
use Benchmark qw(:all :hireswallclock);
-use PublicInbox::Spawn qw(popen_rd);
use Carp ();
require_git(2.19); # for --unordered
require_mods(qw(BSD::Resource));
^ permalink raw reply related [relevance 7%]
* [PATCH 00/10] first steps towards eliminating TIEHANDLE
@ 2023-10-27 22:21 6% Eric Wong
2023-10-27 22:21 7% ` [PATCH 09/10] xt/eml_check_limits: remove useless import Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-10-27 22:21 UTC (permalink / raw)
To: meta
ProcessIO being tied is problematic since perlops like stat
and fcntl don't work directly on the handle, and we need
separate classes to do buffered read and unbuffered sysread.
It's possible to do as common packages (e.g. File::Temp,
IO::Socket::IP, IO::Socket::SSL) do by subclassing IO::Handle
to avoid tie completely. I also want to avoid the self-tie
thing IO::Socket::SSL to avoid having to rely on weaken().
So, this essentially becomes a war on `close($fh)' an relying
on $fh->close where appropriate. This loses some usefulness
of autodie, so we keep `close($fh)' for places which aren't
tied at the moment.
One key place is to replace many calls to popen_rd with the new
run_qx to consolidate close calls. There's also few other
cleanups, code reductions, and safety improvements along the way.
And more changes coming.
Eric Wong (10):
spawn: croak directly in C pi_fork_exec
spawnpp: use autodie for syscall failures
spawn: avoid alloca in C pi_fork_exec
git: use run_qx to read `git --version'
git: avoid extra stat(2) for git version
gcf2: simplify pkg-config and Inline::C setup
treewide: use run_qx where appropriate
www_altid: reduce FD pressure in qspawn queues
xt/eml_check_limits: remove useless import
lei_ale: use v5.12, autodie, and try_cat
lib/PublicInbox/Admin.pm | 7 ++---
lib/PublicInbox/Config.pm | 14 ++++-----
lib/PublicInbox/Fetch.pm | 7 ++---
lib/PublicInbox/Gcf2.pm | 27 +++++-----------
lib/PublicInbox/Git.pm | 15 +++++----
lib/PublicInbox/Import.pm | 6 ++--
lib/PublicInbox/LEI.pm | 7 ++---
lib/PublicInbox/LeiALE.pm | 24 +++++++--------
lib/PublicInbox/LeiBlob.pm | 12 +++-----
lib/PublicInbox/LeiMirror.pm | 7 ++---
lib/PublicInbox/MultiGit.pm | 7 ++---
lib/PublicInbox/Spamcheck/Spamc.pm | 11 ++-----
lib/PublicInbox/Spawn.pm | 49 +++++++++++++++---------------
lib/PublicInbox/SpawnPP.pm | 10 +++---
lib/PublicInbox/WwwAltId.pm | 9 ++----
lib/PublicInbox/XapHelperCxx.pm | 11 ++-----
t/solver_git.t | 12 +++-----
xt/eml_check_limits.t | 4 +--
18 files changed, 94 insertions(+), 145 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-10-27 22:21 6% [PATCH 00/10] first steps towards eliminating TIEHANDLE Eric Wong
2023-10-27 22:21 7% ` [PATCH 09/10] xt/eml_check_limits: remove useless import Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).