* [PATCH 5/6] wwwstream: shorten cloneurl uniquification
2020-01-23 23:05 7% [PATCH 0/6] shorten and simplify uniq logic Eric Wong
@ 2020-01-23 23:05 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-23 23:05 UTC (permalink / raw)
To: meta
Another place where List::Scalar::uniq doesn't make sense,
but there's a small op reduction to be had anyways.
---
lib/PublicInbox/WwwStream.pm | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index 8f5a6526..a724d069 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -89,12 +89,12 @@ sub _html_end {
my $ibx = $ctx->{-inbox};
my $desc = ascii_html($ibx->description);
- my (%seen, @urls);
+ my @urls;
my $http = $self->{base_url};
my $max = $ibx->max_git_epoch;
my $dir = (split(m!/!, $http))[-1];
+ my %seen = ($http => 1);
if (defined($max)) { # v2
- $seen{$http} = 1;
for my $i (0..$max) {
# old parts my be deleted:
-d "$ibx->{inboxdir}/git/$i.git" or next;
@@ -103,15 +103,13 @@ sub _html_end {
push @urls, "$url $dir/git/$i.git";
}
} else { # v1
- $seen{$http} = 1;
push @urls, $http;
}
# FIXME: epoch splits can be different in other repositories,
# use the "cloneurl" file as-is for now:
foreach my $u (@{$ibx->cloneurl}) {
- next if $seen{$u};
- $seen{$u} = 1;
+ next if $seen{$u}++;
push @urls, $u =~ /\Ahttps?:/ ? qq(<a\nhref="$u">$u</a>) : $u;
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] shorten and simplify uniq logic
@ 2020-01-23 23:05 7% Eric Wong
2020-01-23 23:05 7% ` [PATCH 5/6] wwwstream: shorten cloneurl uniquification Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-23 23:05 UTC (permalink / raw)
To: meta
I noticed List::Util 1.45+ includes a new "uniq()" sub, but
that's only distributed with Perl as of 5.26+.
Since we care about supporting older versions of Perl, I still
took the opportunity to simplify some of our own similar logic
for making things unique. It turns out only Inbox->nntp_url
really benefits from List::Util::uniq at the moment, but there's
some small simplifications to be had along the way.
Eric Wong (6):
contentid: use map to generate %seen for Message-Ids
nntp: simplify setting X-Alt-Message-ID
inbox: simplify filtering for duplicate NNTP URLs
mid: shorten uniq_mids logic
wwwstream: shorten cloneurl uniquification
contentid: ignore duplicate References: headers
lib/PublicInbox/ContentId.pm | 12 ++++--------
lib/PublicInbox/Inbox.pm | 11 +++++------
lib/PublicInbox/MID.pm | 4 +---
lib/PublicInbox/NNTP.pm | 5 +----
lib/PublicInbox/OverIdx.pm | 3 +--
lib/PublicInbox/WwwStream.pm | 8 +++-----
6 files changed, 15 insertions(+), 28 deletions(-)
^ permalink raw reply [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-23 23:05 7% [PATCH 0/6] shorten and simplify uniq logic Eric Wong
2020-01-23 23:05 7% ` [PATCH 5/6] wwwstream: shorten cloneurl uniquification Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).