* [PATCH 1/2] wwwlisting: use first successfully loaded JSON module
2020-03-21 1:10 5% ` [PATCH 0/2] wwwlisting: fixup warnings :x Eric Wong
@ 2020-03-21 1:10 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-03-21 1:10 UTC (permalink / raw)
To: meta
And not the last...
I only noticed this since JSON::PP::Boolean was spewing
redefinition warnings via overload.pm
Fixes: 8fb8fc52420ef669 ("wwwlisting: avoid lazy loading JSON module")
---
lib/PublicInbox/WwwListing.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm
index 33cb0ace..42a0c0d8 100644
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -20,7 +20,7 @@ if (eval { require IO::Compress::Gzip }) {
for my $mod (qw(JSON::MaybeXS JSON JSON::PP)) {
eval "require $mod" or next;
# ->ascii encodes non-ASCII to "\uXXXX"
- $json = $mod->new->ascii(1);
+ $json = $mod->new->ascii(1) and last;
}
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] wwwlisting: fixup warnings :x
@ 2020-03-21 1:10 5% ` Eric Wong
2020-03-21 1:10 7% ` [PATCH 1/2] wwwlisting: use first successfully loaded JSON module Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-03-21 1:10 UTC (permalink / raw)
To: meta
I made tests run so quickly that I missed some warnings :x
Eric Wong (2):
wwwlisting: use first successfully loaded JSON module
t/www_listing: avoid 'once' warnings
lib/PublicInbox/WwwListing.pm | 2 +-
t/www_listing.t | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-03-19 8:32 [PATCH 3/6] wwwlisting: avoid lazy loading JSON module Eric Wong
2020-03-21 1:10 5% ` [PATCH 0/2] wwwlisting: fixup warnings :x Eric Wong
2020-03-21 1:10 7% ` [PATCH 1/2] wwwlisting: use first successfully loaded JSON module Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).