* [PATCH 2/6] wwwlisting: favor "use" over require
2020-03-19 8:32 6% [PATCH 0/6] daemon: reduce fragmentation via preload Eric Wong
@ 2020-03-19 8:32 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-03-19 8:32 UTC (permalink / raw)
To: meta
"use" is also evaluated earlier than "require", so it is
favorable for compile-only checking.
---
lib/PublicInbox/WwwListing.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm
index c063fca6..a8aecaf7 100644
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -12,8 +12,8 @@ use PublicInbox::View;
use PublicInbox::Inbox;
use bytes ();
use HTTP::Date qw(time2str);
-require Digest::SHA;
-require File::Spec;
+use Digest::SHA ();
+use File::Spec ();
*try_cat = \&PublicInbox::Inbox::try_cat;
sub list_all_i {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] daemon: reduce fragmentation via preload
@ 2020-03-19 8:32 6% Eric Wong
2020-03-19 8:32 7% ` [PATCH 2/6] wwwlisting: favor "use" over require Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-03-19 8:32 UTC (permalink / raw)
To: meta
For long-lived daemons, perform immortal allocations as early as
possible to reduce the likelyhood of heap fragmentation due to
mixed-lifetime allocations happening once the process is fully
loaded and serving requests, since per-request allocations
should all be short-lived.
On a side note, I'm wondering if WWW should just preload by
default. I'm not sure if anybody uses public-inbox.cgi (or
should be using it :P). It's not like we don't ship
public-inbox-httpd; and any PSGI implementation could be used
for smaller inboxes (or powerful-enough hardware).
Eric Wong (6):
www: update ->preload for newer modules
wwwlisting: favor "use" over require
wwwlisting: avoid lazy loading JSON module
www: avoid `state' usage to perform allocations up-front
daemon: do more immortal allocations up front
viewdiff: favor `qr' to precompile regexps
lib/PublicInbox/NNTPD.pm | 4 +++
lib/PublicInbox/SolverGit.pm | 13 +++++----
lib/PublicInbox/ViewDiff.pm | 53 +++++++++++++++++++----------------
lib/PublicInbox/WWW.pm | 29 ++++++++++++++-----
lib/PublicInbox/WwwListing.pm | 30 +++++++++-----------
t/www_listing.t | 4 +--
6 files changed, 78 insertions(+), 55 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-03-19 8:32 6% [PATCH 0/6] daemon: reduce fragmentation via preload Eric Wong
2020-03-19 8:32 7% ` [PATCH 2/6] wwwlisting: favor "use" over require Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).