user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] www_stream: linkify cloneurl entries if they're HTTP/HTTPS
@ 2016-06-25 22:23  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-06-25 22:23 UTC (permalink / raw)
  To: meta

They may be other public-inbox instances which are browseable,
so provide a link to them to encourage their use as clones.
---
 lib/PublicInbox/WwwStream.pm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index 62a4fe2..34f32c0 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -44,8 +44,6 @@ sub _html_end {
 	my $ctx = $self->{ctx};
 	my $obj = $ctx->{-inbox};
 	my $desc = ascii_html($obj->description);
-	my @urls = @{$obj->cloneurl};
-	my %seen = map { $_ => 1 } @urls;
 
 	# FIXME: cleanup
 	my $env = $ctx->{env};
@@ -54,9 +52,15 @@ sub _html_end {
 			"$env->{SERVER_NAME}:$env->{SERVER_PORT}";
 	my $http = "$scheme://$host_port".($env->{SCRIPT_NAME} || '/');
 	$http = URI->new($http . $obj->{name})->canonical->as_string;
-	$seen{$http} or unshift @urls, $http;
+	my %seen = ( $http => 1 );
+	my @urls = ($http);
+	foreach my $u (@{$obj->cloneurl}) {
+		next if $seen{$u};
+		$seen{$u} = 1;
+		push @urls, $u =~ /\Ahttps?:/ ? qq(<a\nhref="$u">$u</a>) : $u;
+	}
 	if (scalar(@urls) == 1) {
-		$urls .= " git clone --mirror $urls[0]";
+		$urls .= " git clone --mirror $http";
 	} else {
 		$urls .= "\n" .
 			join("\n", map { "\tgit clone --mirror $_" } @urls);
-- 
EW


^ permalink raw reply	[relevance 7%]

Results 1-1 of 1 | reverse | sort options + mbox downloads above
-- links below jump to the message on this page --
2016-06-25 22:23  7% [PATCH] www_stream: linkify cloneurl entries if they're HTTP/HTTPS Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).