* [PATCH 0/7] www_coderepo updates
@ 2023-01-28 11:02 7% Eric Wong
2023-01-28 11:02 6% ` [PATCH 1/7] www_coderepo: tree: quiet and 404 on non-existent refs Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-01-28 11:02 UTC (permalink / raw)
To: meta
Not aiming to achieve feature parity with cgit, but
trying to minimize 404s and provide hints/education for
CLI git usage...
And having an Atom feed for just tags (not all commits) can be
nice...
Eric Wong (7):
www_coderepo: tree: quiet and 404 on non-existent refs
www_coderepo: support /$REPO/tags.atom endpoint
www_coderepo: fix snapshot link generation
www_coderepo: reduce utf8::decode calls
repo_atom: translate: account for multiple args
www_coderepo: support $REPO/refs/{heads,tags}/ endpoints
www_coderepo: summary: fix mis-linkification of `...'
lib/PublicInbox/RepoAtom.pm | 64 +++++++++---
lib/PublicInbox/RepoTree.pm | 22 ++++-
lib/PublicInbox/WwwCoderepo.pm | 173 +++++++++++++++++++++++----------
t/solver_git.t | 15 +++
4 files changed, 209 insertions(+), 65 deletions(-)
^ permalink raw reply [relevance 7%]
* [PATCH 1/7] www_coderepo: tree: quiet and 404 on non-existent refs
2023-01-28 11:02 7% [PATCH 0/7] www_coderepo updates Eric Wong
@ 2023-01-28 11:02 6% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-01-28 11:02 UTC (permalink / raw)
To: meta
Clients should see 404s when attempting to hit files for deleted
branches or tags.
---
lib/PublicInbox/RepoTree.pm | 22 ++++++++++++++++++----
t/solver_git.t | 7 +++++++
2 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/RepoTree.pm b/lib/PublicInbox/RepoTree.pm
index 3a848c6f..25dc5b10 100644
--- a/lib/PublicInbox/RepoTree.pm
+++ b/lib/PublicInbox/RepoTree.pm
@@ -18,10 +18,12 @@ sub rd_404_log {
PublicInbox::WwwStream::html_init($ctx);
my $zfh = $ctx->{zfh};
print $zfh "<pre>\$ git log -1 $tip -- $path\n";
+ my $code = 200;
if ($$bref eq '') {
- say $zfh "found no record of `$path' in git history";
+ say $zfh "found no record of `$path' in git history in `$tip'";
$ctx->{-has_srch} and
say $zfh 'perhaps try searching mail (above)';
+ $code = 404;
} else {
my ($H, $h, $s_as) = split(/ /, $$bref, 3);
utf8::decode($s_as);
@@ -33,17 +35,29 @@ found last record of `$path' in the following commit:
<a href="$ctx->{-upfx}$H/s/?b=$x">$h</a> $s_as
EOM
}
- delete($ctx->{-wcb})->($ctx->html_done);
+ my $res = $ctx->html_done;
+ $res->[0] = $code;
+ delete($ctx->{-wcb})->($res);
}
sub find_missing {
my ($ctx) = @_;
+ if ($ctx->{-path} eq '') {
+ my $tip = 'HEAD';
+ $tip = ascii_html($ctx->{qp}->{h}) if defined($ctx->{qp}->{h});
+ PublicInbox::WwwStream::html_init($ctx);
+ print { $ctx->{zfh} } "<pre>`$tip' ref not found</pre>";
+ my $res = $ctx->html_done;
+ $res->[0] = 404;
+ return delete($ctx->{-wcb})->($res);
+ }
my $cmd = ['git', "--git-dir=$ctx->{git}->{git_dir}",
qw(log --no-color -1), '--pretty=%H %h %s (%as)' ];
push @$cmd, $ctx->{qp}->{h} if defined($ctx->{qp}->{h});
push @$cmd, '--';
- push @$cmd, $ctx->{-path} if $ctx->{-path} ne '';
- my $qsp = PublicInbox::Qspawn->new($cmd);
+ push @$cmd, $ctx->{-path};
+ my $qsp = PublicInbox::Qspawn->new($cmd, undef,
+ { quiet => 1, 2 => $ctx->{lh} });
$qsp->psgi_qx($ctx->{env}, undef, \&rd_404_log, $ctx);
}
diff --git a/t/solver_git.t b/t/solver_git.t
index 122cf888..7743913b 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -396,6 +396,13 @@ EOF
is($res->code, 200, 'got 200 for a directory');
$got = $res->content;
like($got, qr/\bgit ls-tree\b/, 'ls-tree help shown');
+
+ $res = $cb->(GET('/public-inbox/tree/?h=no-branch'));
+ is($res->code, 404, 'got 404 for non-existent ref root');
+ $res = $cb->(GET('/public-inbox/tree/README?h=no-file'));
+ is($res->code, 404, 'got 404 for non-existent ref README');
+ $res = $cb->(GET('/public-inbox/tree/Documentation?h=no-dir'));
+ is($res->code, 404, 'got 404 for non-existent ref directory');
};
test_psgi(sub { $www->call(@_) }, $client);
my $env = { PI_CONFIG => $cfgpath, TMPDIR => $tmpdir };
^ permalink raw reply related [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-01-28 11:02 7% [PATCH 0/7] www_coderepo updates Eric Wong
2023-01-28 11:02 6% ` [PATCH 1/7] www_coderepo: tree: quiet and 404 on non-existent refs Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).