* [PATCH 0/2] www_coderepo: graceful dead branch handling
@ 2023-02-14 13:17 7% Eric Wong
2023-02-14 13:17 6% ` [PATCH 1/2] www_coderepo: quiet 404s on Atom feeds for dead branches Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-02-14 13:17 UTC (permalink / raw)
To: meta
At least make stderr quieter (cgit doesn't spew to stderr on
dead branches, so we shouldn't, either).
Eric Wong (2):
www_coderepo: quiet 404s on Atom feeds for dead branches
www_coderepo: handle unborn/dead branches in summary
lib/PublicInbox/RepoAtom.pm | 3 ++-
lib/PublicInbox/WwwCoderepo.pm | 15 ++++++++-------
t/solver_git.t | 23 ++++++++++++-----------
3 files changed, 22 insertions(+), 19 deletions(-)
^ permalink raw reply [relevance 7%]
* [PATCH 1/2] www_coderepo: quiet 404s on Atom feeds for dead branches
2023-02-14 13:17 7% [PATCH 0/2] www_coderepo: graceful dead branch handling Eric Wong
@ 2023-02-14 13:17 6% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-02-14 13:17 UTC (permalink / raw)
To: meta
No need to clutter up logs when a request hits a dead branch.
---
lib/PublicInbox/RepoAtom.pm | 3 ++-
lib/PublicInbox/WwwCoderepo.pm | 1 +
t/solver_git.t | 5 ++++-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/RepoAtom.pm b/lib/PublicInbox/RepoAtom.pm
index 44883ab4..c89d4551 100644
--- a/lib/PublicInbox/RepoAtom.pm
+++ b/lib/PublicInbox/RepoAtom.pm
@@ -120,7 +120,8 @@ sub srv_atom {
# else: let git decide based on HEAD if $tip isn't defined
push @cmd, '--';
push @cmd, $path if $path ne '';
- my $qsp = PublicInbox::Qspawn->new(\@cmd);
+ my $qsp = PublicInbox::Qspawn->new(\@cmd, undef,
+ { quiet => 1, 2 => $ctx->{lh} });
$qsp->psgi_return($ctx->{env}, undef, \&atom_ok, $ctx);
}
diff --git a/lib/PublicInbox/WwwCoderepo.pm b/lib/PublicInbox/WwwCoderepo.pm
index 7a2cb80b..8a490b6c 100644
--- a/lib/PublicInbox/WwwCoderepo.pm
+++ b/lib/PublicInbox/WwwCoderepo.pm
@@ -308,6 +308,7 @@ sub srv { # endpoint called by PublicInbox::WWW
PublicInbox::RepoSnapshot::srv($ctx, $2) // r(404);
} elsif ($path_info =~ m!\A/(.+?)/atom/(.*)\z! and
($ctx->{git} = $cr->{$1})) {
+ $ctx->{lh} = $self->{log_fh};
PublicInbox::RepoAtom::srv_atom($ctx, $2) // r(404);
} elsif ($path_info =~ m!\A/(.+?)/tags\.atom\z! and
($ctx->{git} = $cr->{$1})) {
diff --git a/t/solver_git.t b/t/solver_git.t
index 0090bc06..79672398 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -379,7 +379,10 @@ EOF
ok($t->{feed}->{entry}, 'got entry');
$res = $cb->(GET('/public-inbox/atom/README.md'));
- is($res->code, 404, '404 on non-existent file Atom feed');
+ is($res->code, 404, '404 on missing file Atom feed');
+
+ $res = $cb->(GET('/public-inbox/atom/?h=gone'));
+ is($res->code, 404, '404 on missing Atom feed branch');
}
$res = $cb->(GET('/public-inbox/tree/'));
^ permalink raw reply related [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-02-14 13:17 7% [PATCH 0/2] www_coderepo: graceful dead branch handling Eric Wong
2023-02-14 13:17 6% ` [PATCH 1/2] www_coderepo: quiet 404s on Atom feeds for dead branches Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).